a few details in combinat, as suggested by ruff #36392
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Documentation preview for this PR (built with commit 47cbfa7; changes) is ready! 🎉 |
dcoudert
reviewed
Oct 6, 2023
src/sage/combinat/partition.py
Outdated
| @@ -4201,8 +4201,8 @@ def zero_one_sequence(self): | |||
| sage: all(Partitions().from_zero_one(mu.zero_one_sequence()) == mu for n in range(10) for mu in Partitions(n)) | |||
| True | |||
| """ | |||
| tmp = [self[i]-i for i in range(len(self))] | |||
| return ([Integer(not (i in tmp)) for i in range(-len(self)+1,self.get_part(0)+1)]) | |||
| tmp = [self[i] - i for i in range(len(self))] | |||
There was a problem hiding this comment.
May be tmp should be a set and not a list. I'm not sure if it is interesting here, and I agree it's not the object of this PR.
|
merge conflict |
|
back to positive after trivial resolution of conflict |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this is fixing a few things in combinat, as suggested by the very fast linter
ruff📝 Checklist