-
-
Notifications
You must be signed in to change notification settings - Fork 553
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
checking that the system maxima has working help #36391
Conversation
the puzzling pattern checked there is due to broken/no Maxima's help giving
|
Even though this makes sense, this should be fixed at the docker CI level first as noted in #36028 (comment). Otherwise building on Arch with system maxima will no longer be tested. |
should I change |
I don't see where the image is installed in CI. There are a number of places |
|
Documentation preview for this PR (built with commit 7cd0cb6; changes) is ready! 🎉 |
can we handle this in another, archlinux-specific, PR? |
Would --- a/build/bin/write-dockerfile.sh
+++ b/build/bin/write-dockerfile.sh
@@ -104,6 +104,7 @@ EOF
UPDATE="pacman -Sy &&"
EXISTS="pacman -Si"
INSTALL="pacman -Su --noconfirm"
+ RUN="RUN sed -i '/^NoExtract/d' /etc/pacman.conf"
;;
nix*)
# https://hub.docker.com/r/nixos/nix do the trick, or I misunderstand what |
as far as I can see, test on arch fails due to missing container:
|
This is needed for e.g. building Sage docs, cf e.g. Sage's sagemath#36028. Some distos mix this up. This fix was requested there.
1066b44
to
ef67ba0
Compare
I've fixed it for you |
I don't understand what it does. Does it create a file? A script to run? |
The script writes a Dockerfile to stdout |
Hmm, and why it's not just using |
That would be equivalent, of course, but this file uses HERE docs for various multi-line snippets, and so it also does single-line snippets in the same way for consistency. |
sagemathgh-36959: `.devcontainer/downstream-archlinux-latest`: Fix maxima Dev container configurations `.devcontainer/downstream-*` give easy access to Sage as provided by downstream packagers (see https://doc.sage math.org/html/en/developer/portability_testing.html#using-our-pre-built- docker-images-for-development-in-vs-code, bottom). Unfortunately maxima is defective when the archlinux sage package is installed in the official archlinux Docker container because of NoExtract directives that make the maxima help system inoperable. Here we apply the same fix that we used in sagemath#36391 for the portability CI: Removing the NoExtract directives before installing the package. <!-- ^^^^^ Please provide a concise, informative and self-explanatory title. Don't put issue numbers in there, do this in the PR body below. For example, instead of "Fixes sagemath#1234" use "Introduce new method to calculate 1+1" --> <!-- Describe your changes here in detail --> <!-- Why is this change required? What problem does it solve? --> <!-- If this PR resolves an open issue, please link to it here. For example "Fixes sagemath#12345". --> <!-- If your change requires a documentation PR, please link it appropriately. --> ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> <!-- If your change requires a documentation PR, please link it appropriately --> <!-- If you're unsure about any of these, don't hesitate to ask. We're here to help! --> <!-- Feel free to remove irrelevant items. --> - [x] The title is concise, informative, and self-explanatory. - [ ] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation accordingly. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on - sagemath#12345: short description why this is a dependency - sagemath#34567: ... --> <!-- If you're unsure about any of these, don't hesitate to ask. We're here to help! --> URL: sagemath#36959 Reported by: Matthias Köppe Reviewer(s): Kwankyu Lee
This is needed for e.g. building Sage docs, cf
e.g. Sage's #36028. Some distos mix this up.
Fixes #36028