Add cycle_type() and fix to_cycle() to SignedPermutation. #36224
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This was done jointly with Arvind Ayyer @ayyer during SageDays 122. We have cross reviewed each others' code. @mantepse @fchapoton Can one of you double-check and approve the PR? |
|
The definition of negative cycle in |
mantepse
reviewed
Sep 9, 2023
mantepse
reviewed
Sep 9, 2023
mantepse
reviewed
Sep 11, 2023
|
Documentation preview for this PR (built with commit e3397a7; changes) is ready! 🎉 |
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Sep 14, 2023
sagemathgh-36224: Add cycle_type() and fix to_cycle() to SignedPermutation. <!-- ^^^^^ Please provide a concise, informative and self-explanatory title. Don't put issue numbers in there, do this in the PR body below. For example, instead of "Fixes sagemath#1234" use "Introduce new method to calculate 1+1" --> <!-- Describe your changes here in detail --> We fix a "bug" in `to_cycle()` of `SignedPermutation` that does not return the negation of a positive cycle, and add an option to hide these cycles (the current behavior in Sage). We add a `cycle_type()` method that returns the corresponding `PartitionTuple` object. We add a `conjugacy_class_reprensentative()` method. A while-we-are-at-it thing: we fix a bug in the error output for `Permutation.element_in_conjugacy_class()` (which a better name IMO is `conjugacy_class_reprensentative()`). <!-- Why is this change required? What problem does it solve? --> <!-- If this PR resolves an open issue, please link to it here. For example "Fixes sagemath#12345". --> <!-- If your change requires a documentation PR, please link it appropriately. --> ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> <!-- If your change requires a documentation PR, please link it appropriately --> <!-- If you're unsure about any of these, don't hesitate to ask. We're here to help! --> <!-- Feel free to remove irrelevant items. --> - [x] The title is concise, informative, and self-explanatory. - [x] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. - [x] I have created tests covering the changes. - [x] I have updated the documentation accordingly. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on - sagemath#12345: short description why this is a dependency - sagemath#34567: ... --> <!-- If you're unsure about any of these, don't hesitate to ask. We're here to help! --> URL: sagemath#36224 Reported by: Travis Scrimshaw Reviewer(s): ayyer, Martin Rubey, Travis Scrimshaw
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We fix a "bug" in
to_cycle()ofSignedPermutationthat does not return the negation of a positive cycle, and add an option to hide these cycles (the current behavior in Sage).We add a
cycle_type()method that returns the correspondingPartitionTupleobject.We add a
conjugacy_class_reprensentative()method.A while-we-are-at-it thing: we fix a bug in the error output for
Permutation.element_in_conjugacy_class()(which a better name IMO isconjugacy_class_reprensentative()).📝 Checklist
⌛ Dependencies