Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop obsolete html5lib package #36186

Merged
merged 2 commits into from
Sep 16, 2023
Merged

Conversation

orlitzky
Copy link
Contributor

@orlitzky orlitzky commented Sep 3, 2023

I'm pretty sure this package is obsolete, let's see.

@jhpalmieri
Copy link
Member

This looks okay to me. Sage builds and passes tests, and html5lib is not mentioned anywhere in the source code except in its own build directory.

@kwankyu
Copy link
Collaborator

kwankyu commented Sep 7, 2023

I don't know if this is worth to be kept or not. But this is a standard package. What is the drop procedure of a standard package? I couldn't find anything in the developer manual.

It seems reasonable to me there is a one-year deprecation period when we drop a (standard) package. Or needs a discussion in sage-devel?

Is there an established procedure? There must be precedents. @mkoeppe @jhpalmieri ?

@jhpalmieri
Copy link
Member

I find it very unlikely that someone both (a) relies on html5lib in Sage and (b) can't pip-install it themselves. I don't see a need for a deprecation period. About two years ago we removed ATLAS (#30350) and mpir (#32549) without any deprecation, so there is precedent.

@kwankyu
Copy link
Collaborator

kwankyu commented Sep 7, 2023

OK. Thanks.

@mkoeppe
Copy link
Contributor

mkoeppe commented Sep 7, 2023

I agree with John that a deprecation period is not needed for changes like this. This package was added because it was a dependency of another standard package, bleach, which is a dependency of the user-facing package nbconvert, which is invoked by a Jupyter menu item.

By the way, html5lib is not really "obsolete". We just don't need to install it any more because bleach started to vendor its own copy of html5lib 1.1 at some point.

@vbraun
Copy link
Member

vbraun commented Sep 10, 2023

merge conflict

This was originally a dependency of bleach, but bleach doesn't need it
any more.
While investigating whether or not tinycss2 is obsolete, it was
discovered that nbconvert (still) needs it.
@github-actions
Copy link

Documentation preview for this PR (built with commit 15e68e4; changes) is ready! 🎉

@vbraun vbraun merged commit 1a1df6f into sagemath:develop Sep 16, 2023
@mkoeppe mkoeppe added this to the sage-10.2 milestone Sep 16, 2023
@orlitzky orlitzky deleted the drop-html5lib branch September 22, 2023 00:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants