-
-
Notifications
You must be signed in to change notification settings - Fork 553
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve method is_planar #36021
Improve method is_planar #36021
Conversation
ping |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but could you make one small tweak to the error message outputs and put one extra space on the second line after the break; e.g.,
NotImplementedError: a really long
doctest output line
Once done, you can set a positive review.
Thank you for the review. |
Documentation preview for this PR (built with commit 933707f; changes) is ready! 🎉 |
Fixes #35152.
We improve the method to avoid working with embeddings when the input (di)graph has multiple edges or loops, or when the input digraph has pairs of opposite arcs. In these cases, the notion of embedding is not consistently defined so far as it mixes neighbors and incident edges.
We now allow to set positions whenever embeddings are not involved.
We also avoid modifying the input graph in method
is_planar
fromplanarity.pyx
and reorder some operations.📝 Checklist
⌛ Dependencies