Implement Goss polynomials of Drinfeld modules #35991
Conversation
src/sage/rings/function_field/drinfeld_modules/drinfeld_module.py
Outdated
Show resolved
Hide resolved
src/sage/rings/function_field/drinfeld_modules/drinfeld_module.py
Outdated
Show resolved
Hide resolved
src/sage/rings/function_field/drinfeld_modules/drinfeld_module.py
Outdated
Show resolved
Hide resolved
|
Thanks for the comments, I think I have addressed all of them. |
src/sage/rings/function_field/drinfeld_modules/drinfeld_module.py
Outdated
Show resolved
Hide resolved
Co-authored-by: Xavier Caruso <[email protected]>
There was a problem hiding this comment.
Thanks for this contribution @DavidAyotte. I approve the changes.
|
It seems that they are currently problems with automatic checkings. |
|
Cc @vbraun |
|
I have re-launched the checks on top of 10.1. The branch has been re-based. |
Thanks Frédéric! The failing doctest does not seem to be related to this branch. |
|
Indeed, it is unrelated. Feel free to set to positive if you think this is ready. |
|
but note that the added raise is not correctly doctested |
|
Good point, Frédéric. |
|
Thanks for pointing this out. I added the desired doctest. |
|
Documentation preview for this PR (built with commit 09fbdfa; changes) is ready! 🎉 |
sagemathgh-35991: Implement Goss polynomials of Drinfeld modules <!-- ^^^^^ Please provide a concise, informative and self-explanatory title. Don't put issue numbers in there, do this in the PR body below. For example, instead of "Fixes sagemath#1234" use "Introduce new method to calculate 1+1" --> <!-- Describe your changes here in detail --> <!-- Why is this change required? What problem does it solve? --> <!-- If this PR resolves an open issue, please link to it here. For example "Fixes sagemath#12345". --> <!-- If your change requires a documentation PR, please link it appropriately. --> This PR implements Goss polynomials of Drinfeld modules. The interested PR reviewer should read section 3 of [this paper](https://link.springer.com/article/10.1007/BF01410204). In particular, the recurrence relation (ii) of Proposition 3.4 of op. cit. is used in order to compute the $n$-th Goss polynomial of a Drinfeld module. CC: @xcaruso @ymusleh @kryzar ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> <!-- If your change requires a documentation PR, please link it appropriately --> <!-- If you're unsure about any of these, don't hesitate to ask. We're here to help! --> <!-- Feel free to remove irrelevant items. --> - [X] The title is concise, informative, and self-explanatory. - [X] The description explains in detail what this PR is about. - [X] I have linked a relevant issue or discussion. - [X] I have created tests covering the changes. - [X] I have updated the documentation accordingly. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on - sagemath#12345: short description why this is a dependency - sagemath#34567: ... --> <!-- If you're unsure about any of these, don't hesitate to ask. We're here to help! --> URL: sagemath#35991 Reported by: David Ayotte Reviewer(s): Antoine Leudière, Xavier Caruso
This PR implements Goss polynomials of Drinfeld modules. The interested PR reviewer should read section 3 of this paper. In particular, the recurrence relation (ii) of Proposition 3.4 of op. cit. is used in order to compute the$n$ -th Goss polynomial of a Drinfeld module.
CC: @xcaruso @ymusleh @kryzar
📝 Checklist
⌛ Dependencies