Fix GradedModularFormElement multiplication #35978
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grhkm21
force-pushed
the
grhkm/issue-35932
branch
from
dcc453c to
eb915f2
Compare
grhkm21
force-pushed
the
grhkm/issue-35932
branch
from
eb915f2 to
cd50695
Compare
|
@DavidAyotte Hi, this is the new issue that I created for fixing multiplication. Took me a while to figure out how to get git working (rebase/stash/branch checkout/...). It should be ready |
DavidAyotte
suggested changes
Jul 22, 2023
Applying David's styling suggestions Co-authored-by: David Ayotte <[email protected]>
|
I have done that, thanks a lot |
|
Can a maintainer accept the workflow runs for this Pull Request? @mkoeppe ? Thanks in advance. |
mkoeppe
reviewed
Jul 22, 2023
|
Documentation preview for this PR (built with commit 24e32c6; changes) is ready! 🎉 |
DavidAyotte
reviewed
Jul 23, 2023
DavidAyotte
approved these changes
Oct 12, 2023
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Oct 15, 2023
sagemathgh-35978: Fix GradedModularFormElement multiplication Fix sagemath#35932 - incorrect multiplication for GradedModularFormElement. ### 📝 Checklist - [x] The title is concise, informative, and self-explanatory. - [x] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. - [x] I have created tests covering the changes. - [x] I have updated the documentation accordingly. URL: sagemath#35978 Reported by: grhkm21 Reviewer(s): David Ayotte, grhkm21, Matthias Köppe
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Oct 17, 2023
sagemathgh-35978: Fix GradedModularFormElement multiplication Fix sagemath#35932 - incorrect multiplication for GradedModularFormElement. ### 📝 Checklist - [x] The title is concise, informative, and self-explanatory. - [x] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. - [x] I have created tests covering the changes. - [x] I have updated the documentation accordingly. URL: sagemath#35978 Reported by: grhkm21 Reviewer(s): David Ayotte, grhkm21, Matthias Köppe
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #35932 - incorrect multiplication for GradedModularFormElement.
📝 Checklist