Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI build.yml, doc-build.yml: Use output groups #35866

Merged
merged 5 commits into from
Sep 27, 2023

Conversation

mkoeppe
Copy link
Contributor

@mkoeppe mkoeppe commented Jun 30, 2023

📚 Description

With this change, the output of each spkg build is put in foldable output groups.

The output synchronization is not perfect, but it's still much better than before.

📝 Checklist

  • The title is concise, informative, and self-explanatory.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation accordingly.

⌛ Dependencies

@mkoeppe mkoeppe self-assigned this Jun 30, 2023
@mkoeppe mkoeppe force-pushed the ci_build_use_output_groups branch from 597dffb to dd3db33 Compare June 30, 2023 14:54
@mkoeppe mkoeppe requested review from dimpase and tobiasdiez June 30, 2023 15:52
@mkoeppe mkoeppe force-pushed the ci_build_use_output_groups branch from 95705ba to 2ec3707 Compare July 30, 2023 19:43
@mkoeppe mkoeppe requested a review from kliem September 26, 2023 16:05
@mkoeppe mkoeppe force-pushed the ci_build_use_output_groups branch from 2ec3707 to fd6b030 Compare September 27, 2023 03:10
@mkoeppe mkoeppe requested a review from kwankyu September 27, 2023 03:11
Copy link
Collaborator

@kwankyu kwankyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK. Looks nice.

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Sep 27, 2023

Thanks!

@github-actions
Copy link

Documentation preview for this PR (built with commit fd6b030; changes) is ready! 🎉

@vbraun vbraun merged commit 5cef467 into sagemath:develop Sep 27, 2023
@mkoeppe mkoeppe added this to the sage-10.2 milestone Sep 27, 2023
@mkoeppe mkoeppe deleted the ci_build_use_output_groups branch September 28, 2023 20:51
vbraun pushed a commit to vbraun/sage that referenced this pull request Oct 19, 2023
sagemathgh-36473: CI docbuild: Do not rebuild sagelib from scratch
    
<!-- ^^^^^
Please provide a concise, informative and self-explanatory title.
Don't put issue numbers in there, do this in the PR body below.
For example, instead of "Fixes sagemath#1234" use "Introduce new method to
calculate 1+1"
-->
<!-- Describe your changes here in detail -->

Reworking sagemath#35652 as discussed in
sagemath#36469 (comment)

Also applying the changes made in sagemath#35866 (cosmetic improvements to the
Actions logs of doc-build.yml) to doc-build-pdf.yml

<!-- Why is this change required? What problem does it solve? -->
<!-- If this PR resolves an open issue, please link to it here. For
example "Fixes sagemath#12345". -->
<!-- If your change requires a documentation PR, please link it
appropriately. -->

### 📝 Checklist

<!-- Put an `x` in all the boxes that apply. -->
<!-- If your change requires a documentation PR, please link it
appropriately -->
<!-- If you're unsure about any of these, don't hesitate to ask. We're
here to help! -->
<!-- Feel free to remove irrelevant items. -->

- [x] The title is concise, informative, and self-explanatory.
- [ ] The description explains in detail what this PR is about.
- [x] I have linked a relevant issue or discussion.
- [ ] I have created tests covering the changes.
- [ ] I have updated the documentation accordingly.

### ⌛ Dependencies

<!-- List all open PRs that this PR logically depends on
- sagemath#12345: short description why this is a dependency
- sagemath#34567: ...
-->

<!-- If you're unsure about any of these, don't hesitate to ask. We're
here to help! -->
    
URL: sagemath#36473
Reported by: Matthias Köppe
Reviewer(s): Kwankyu Lee, Matthias Köppe
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants