Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add order_from_multiple() to sage.groups.all #35503

Conversation

yyyyx4
Copy link
Member

@yyyyx4 yyyyx4 commented Apr 14, 2023

This function is very useful for some computations involving elliptic curves over finite fields and I don't see a reason not to import it by default.

@yyyyx4 yyyyx4 force-pushed the public/add_order_from_multiple_to_sage_groups_all branch from f6b7613 to 2bcd4ce Compare May 24, 2023 05:18
@yyyyx4 yyyyx4 force-pushed the public/add_order_from_multiple_to_sage_groups_all branch from 2bcd4ce to e9ff724 Compare August 21, 2023 20:52
@yyyyx4 yyyyx4 force-pushed the public/add_order_from_multiple_to_sage_groups_all branch from e9ff724 to 3943338 Compare September 21, 2023 14:51
@yyyyx4 yyyyx4 force-pushed the public/add_order_from_multiple_to_sage_groups_all branch from 3943338 to be644f9 Compare November 10, 2023 13:17
@yyyyx4 yyyyx4 force-pushed the public/add_order_from_multiple_to_sage_groups_all branch from be644f9 to d073325 Compare January 1, 2024 15:49
Copy link

github-actions bot commented Jan 1, 2024

Documentation preview for this PR (built with commit d073325; changes) is ready! 🎉

Copy link
Contributor

@GiacomoPope GiacomoPope left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is something I have had to code by hand as I did not know it was available. I agree it should be made more present in the code.

vbraun pushed a commit to vbraun/sage that referenced this pull request Feb 7, 2024
sagemathgh-35503: add order_from_multiple() to sage.groups.all
    
This function is very useful for some computations involving elliptic
curves over finite fields and I don't see a reason not to import it by
default.
    
URL: sagemath#35503
Reported by: Lorenz Panny
Reviewer(s): Giacomo Pope
@vbraun vbraun merged commit 2369ddb into sagemath:develop Feb 13, 2024
5 checks passed
@yyyyx4 yyyyx4 deleted the public/add_order_from_multiple_to_sage_groups_all branch February 14, 2024 02:55
@mkoeppe mkoeppe added this to the sage-10.3 milestone Mar 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants