Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update msolve to 0.4.9 #35159

Merged
merged 4 commits into from
Mar 26, 2023
Merged

update msolve to 0.4.9 #35159

merged 4 commits into from
Mar 26, 2023

Conversation

dimpase
Copy link
Member

@dimpase dimpase commented Feb 18, 2023

update to a new version

@dimpase dimpase marked this pull request as draft February 18, 2023 23:15
@dimpase
Copy link
Member Author

dimpase commented Feb 18, 2023

I've asked them to start uploading configured tarballs: algebraic-solving/msolve#36

@codecov-commenter
Copy link

codecov-commenter commented Feb 19, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (52a81cb) 88.57% compared to head (5e79f6a) 88.58%.

❗ Current head 5e79f6a differs from pull request most recent head 99dcc4d. Consider uploading reports for the commit 99dcc4d to get more accurate results

Additional details and impacted files
@@            Coverage Diff            @@
##           develop   #35159    +/-   ##
=========================================
  Coverage    88.57%   88.58%            
=========================================
  Files         2140     2140            
  Lines       397273   396998   -275     
=========================================
- Hits        351891   351683   -208     
+ Misses       45382    45315    -67     
Impacted Files Coverage Δ
src/sage/quadratic_forms/random_quadraticform.py 90.00% <0.00%> (-6.00%) ⬇️
src/sage/rings/continued_fraction_gosper.py 97.05% <0.00%> (-2.95%) ⬇️
src/sage/groups/additive_abelian/qmodnz.py 91.48% <0.00%> (-2.13%) ⬇️
src/sage/modular/local_comp/liftings.py 98.33% <0.00%> (-1.67%) ⬇️
src/sage/graphs/generators/random.py 91.26% <0.00%> (-1.20%) ⬇️
...c/sage/schemes/elliptic_curves/ell_finite_field.py 87.74% <0.00%> (-1.10%) ⬇️
src/sage/combinat/matrices/hadamard_matrix.py 84.43% <0.00%> (-1.01%) ⬇️
...e/combinat/cluster_algebra_quiver/mutation_type.py 51.42% <0.00%> (-0.72%) ⬇️
src/sage/groups/generic.py 88.34% <0.00%> (-0.68%) ⬇️
src/sage/modular/modform/numerical.py 94.19% <0.00%> (-0.65%) ⬇️
... and 43 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@dimpase dimpase marked this pull request as ready for review February 19, 2023 10:04
@dimpase
Copy link
Member Author

dimpase commented Feb 19, 2023

I'm hosting configured tarball on a GitHub fork, for the time being.

@dimpase
Copy link
Member Author

dimpase commented Feb 20, 2023

upstream provided a proper tarball: algebraic-solving/msolve#36

@mkoeppe
Copy link
Contributor

mkoeppe commented Feb 20, 2023

Works fine on macOS.

@mkoeppe mkoeppe added this to the sage-10.0 milestone Feb 20, 2023
@github-actions
Copy link

Documentation preview for this PR is ready! 🎉
Built with commit: 5e79f6a

SageMath version 10.0.beta3, Release Date: 2023-03-02
@vbraun vbraun merged commit 6d14679 into sagemath:develop Mar 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants