-
-
Notifications
You must be signed in to change notification settings - Fork 602
Meson build: build dir is hardcoded in sage.config #39870
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
@antonio-rojas please review the pr |
The PR doesn't work, the
|
sagemathgh-39885: Provided a default value for SAGE_ROOT that can be overridden by an environment variable or configuration file <!-- ^ Please provide a concise and informative title. --> <!-- ^ Don't put issue numbers in the title, do this in the PR description below. --> <!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method to calculate 1 + 2". --> <!-- v Describe your changes below in detail. --> <!-- v Why is this change required? What problem does it solve? --> <!-- v If this PR resolves an open issue, please link to it here. For example, "Fixes sagemath#12345". --> This PR fixes sagemath#39870 added following code to `env.py` ``` DEFAULT_SAGE_ROOT = "" SAGE_ROOT = var("SAGE_ROOT", DEFAULT_SAGE_ROOT) ``` to ensure that `SAGE_ROOT` is not hardcoded and can be dynamically set or overridden ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [ ] The title is concise and informative. - [ ] The description explains in detail what this PR is about. - [ ] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on. For example, --> <!-- - sagemath#12345: short description why this is a dependency --> <!-- - sagemath#34567: ... --> URL: sagemath#39885 Reported by: Krishna Dubey Reviewer(s): Antonio Rojas, Tobias Diez
sagemathgh-39885: Provided a default value for SAGE_ROOT that can be overridden by an environment variable or configuration file <!-- ^ Please provide a concise and informative title. --> <!-- ^ Don't put issue numbers in the title, do this in the PR description below. --> <!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method to calculate 1 + 2". --> <!-- v Describe your changes below in detail. --> <!-- v Why is this change required? What problem does it solve? --> <!-- v If this PR resolves an open issue, please link to it here. For example, "Fixes sagemath#12345". --> This PR fixes sagemath#39870 added following code to `env.py` ``` DEFAULT_SAGE_ROOT = "" SAGE_ROOT = var("SAGE_ROOT", DEFAULT_SAGE_ROOT) ``` to ensure that `SAGE_ROOT` is not hardcoded and can be dynamically set or overridden ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [ ] The title is concise and informative. - [ ] The description explains in detail what this PR is about. - [ ] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on. For example, --> <!-- - sagemath#12345: short description why this is a dependency --> <!-- - sagemath#34567: ... --> URL: sagemath#39885 Reported by: Krishna Dubey Reviewer(s): Antonio Rojas, Tobias Diez
sagemathgh-39885: Provided a default value for SAGE_ROOT that can be overridden by an environment variable or configuration file <!-- ^ Please provide a concise and informative title. --> <!-- ^ Don't put issue numbers in the title, do this in the PR description below. --> <!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method to calculate 1 + 2". --> <!-- v Describe your changes below in detail. --> <!-- v Why is this change required? What problem does it solve? --> <!-- v If this PR resolves an open issue, please link to it here. For example, "Fixes sagemath#12345". --> This PR fixes sagemath#39870 added following code to `env.py` ``` DEFAULT_SAGE_ROOT = "" SAGE_ROOT = var("SAGE_ROOT", DEFAULT_SAGE_ROOT) ``` to ensure that `SAGE_ROOT` is not hardcoded and can be dynamically set or overridden ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [ ] The title is concise and informative. - [ ] The description explains in detail what this PR is about. - [ ] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on. For example, --> <!-- - sagemath#12345: short description why this is a dependency --> <!-- - sagemath#34567: ... --> URL: sagemath#39885 Reported by: Krishna Dubey Reviewer(s): Antonio Rojas, Tobias Diez
Steps To Reproduce
SAGE_ROOT
should be empty in sagelib except if explicitly specified (eg. by sage-the-distro). Otherwise things break badly for distro packages:Expected Behavior
SAGE_ROOT
is unset (soexpand_files_into_sources()
works properly)Actual Behavior
See above
Additional Information
No response
Environment
Checklist
The text was updated successfully, but these errors were encountered: