Skip to content

upgrade meson to 1.7.0 #39490

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
dimpase opened this issue Feb 10, 2025 · 2 comments · Fixed by #39492
Closed

upgrade meson to 1.7.0 #39490

dimpase opened this issue Feb 10, 2025 · 2 comments · Fixed by #39492

Comments

@dimpase
Copy link
Member

dimpase commented Feb 10, 2025

          > On macos (mac mini m2) I'm getting
[cysignals-1.12.3] [spkg-install] The Meson build system
[cysignals-1.12.3] [spkg-install] Version: 1.3.1
[cysignals-1.12.3] [spkg-install] Source dir: /Users/buildbot-sage/worker/sage_git/build/local/var/lib/sage/venv-python3.12.5/var/tmp/sage/build/cysignals-1.12.3/src
[cysignals-1.12.3] [spkg-install] Build dir: /Users/buildbot-sage/worker/sage_git/build/local/var/lib/sage/venv-python3.12.5/var/tmp/sage/build/cysignals-1.12.3/src/.mesonpy-oe6svlmq
[cysignals-1.12.3] [spkg-install] Build type: native build
[cysignals-1.12.3] [spkg-install] Project name: cysignals
[cysignals-1.12.3] [spkg-install] Project version: undefined
[cysignals-1.12.3] [spkg-install] C compiler for the host machine: gcc (clang 15.0.0 "Apple clang version 15.0.0 (clang-1500.3.9.4)")
[cysignals-1.12.3] [spkg-install] C linker for the host machine: gcc ld64 classic  PROJECT:ld64
[cysignals-1.12.3] [spkg-install] 
[cysignals-1.12.3] [spkg-install] ../meson.build:1:0: ERROR: Unable to get clang pre-processor defines:
[cysignals-1.12.3] [spkg-install] Compiler stdout:
[cysignals-1.12.3] [spkg-install] 
[cysignals-1.12.3] [spkg-install] -----
[cysignals-1.12.3] [spkg-install] Compiler stderr:
[cysignals-1.12.3] [spkg-install] error: invalid argument '-std=gnu++11' not allowed with 'C'
[cysignals-1.12.3] [spkg-install] 
[cysignals-1.12.3] [spkg-install] -----

This should be fixed in more recent versions of meson, eg with mesonbuild/meson#13289.

Originally posted by @tobiasdiez in #38749 (comment)

@dimpase
Copy link
Member Author

dimpase commented Feb 10, 2025

The current version is 1.7.0, already on Homebrew. Perhaps that's why people don't see this all the time.

@dimpase
Copy link
Member Author

dimpase commented Feb 10, 2025

@tobiasdiez @vbraun

vbraun pushed a commit to vbraun/sage that referenced this issue Feb 27, 2025
sagemathgh-39492: update meson and meson-python to the latest versions,  1.7.0 and 0.7.1
    
Meson update is needed to deal with the issue found on  sagemath#38749
A straightforward update. This will fix sagemath#39490

In particular, building of the latest cysignals on macOS might need
this.

### 📝 Checklist

<!-- Put an `x` in all the boxes that apply. -->

- [x] The title is concise and informative.
- [x] The description explains in detail what this PR is about.
- [x] I have linked a relevant issue or discussion.
- [ ] I have created tests covering the changes.
- [ ] I have updated the documentation and checked the documentation
preview.

### ⌛ Dependencies

<!-- List all open PRs that this PR logically depends on. For example,
-->
<!-- - sagemath#12345: short description why this is a dependency -->
<!-- - sagemath#34567: ... -->
    
URL: sagemath#39492
Reported by: Dima Pasechnik
Reviewer(s): Tobias Diez
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant