Skip to content

Upgrade eclib to version v20241112 #38960

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
1 task done
JohnCremona opened this issue Nov 12, 2024 · 0 comments
Open
1 task done

Upgrade eclib to version v20241112 #38960

JohnCremona opened this issue Nov 12, 2024 · 0 comments
Assignees
@JohnCremona
Labels
c: packages: standard dependencies Pull requests that update a dependency file t: enhancement

Comments

@JohnCremona
Copy link
Member

Problem Description

The current version of eclib in Sage is 20231212. I don't know why we never upgraded to version 20240408, but now I have just realeased 20241112 and will do what is necessary.

Proposed Solution

I will package up eclib version 20241112 and make sure that it builds, and that any doctest adjustments have been made, and will then make a PR.

Alternatives Considered

I considered doing nothing but decided not to.

Additional Information

This is not a bug, nor a build problem, nor a feature request, but we seem to not have a category for it so I chose Feature Request.

Is there an existing issue for this?

  • I have searched the existing issues for a bug report that matches the one I want to file, without success.
@JohnCremona JohnCremona added t: enhancement c: packages: standard dependencies Pull requests that update a dependency file labels Nov 12, 2024
@JohnCremona JohnCremona self-assigned this Nov 12, 2024
@JohnCremona JohnCremona mentioned this issue Nov 13, 2024
Closed
3 tasks
JohnCremona added a commit to JohnCremona/sage that referenced this issue Nov 19, 2024
@JohnCremona
sagemath#38960 fix eclib interface after upgrade
28c0400
JohnCremona added a commit to JohnCremona/sage that referenced this issue Nov 19, 2024
@JohnCremona
sagemath#38960-eclib-upgrade-20241112
01d3463
JohnCremona added a commit to JohnCremona/sage that referenced this issue Nov 19, 2024
@JohnCremona
sagemath#38960 fix eclib interface after upgrade
6967897
JohnCremona added a commit to JohnCremona/sage that referenced this issue Dec 4, 2024
@JohnCremona
sagemath#38960-eclib-upgrade-20241112
cc34d94
JohnCremona added a commit to JohnCremona/sage that referenced this issue Dec 4, 2024
@JohnCremona
sagemath#38960 fix eclib interface after upgrade
1b3d718
JohnCremona added a commit to JohnCremona/sage that referenced this issue Dec 4, 2024
@JohnCremona
sagemath#38960 simplify eclib interface
f0dc04f
JohnCremona added a commit to JohnCremona/sage that referenced this issue Dec 4, 2024
@JohnCremona
sagemath#38960: fix lint issue
48bbf7e
JohnCremona added a commit to JohnCremona/sage that referenced this issue Dec 4, 2024
@JohnCremona
sagemath#38960-eclib-upgrade-20241112
6dfc26b
JohnCremona added a commit to JohnCremona/sage that referenced this issue Dec 4, 2024
@JohnCremona
sagemath#38960 fix eclib interface after upgrade
d38cb48
JohnCremona added a commit to JohnCremona/sage that referenced this issue Dec 4, 2024
@JohnCremona
sagemath#38960 simplify eclib interface
4f2cb3f
JohnCremona added a commit to JohnCremona/sage that referenced this issue Dec 4, 2024
@JohnCremona
sagemath#38960: fix lint issue
8754c70
vbraun pushed a commit to vbraun/sage that referenced this issue Dec 6, 2024
ce4da41 
sagemathgh-38962: Upgrade eclib to version 20241112
    
<!-- ^ Please provide a concise and informative title. -->
<!-- ^ Don't put issue numbers in the title, do this in the PR
description below. -->
<!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method
to calculate 1 + 2". -->
<!-- v Describe your changes below in detail. -->
<!-- v Why is this change required? What problem does it solve? -->
<!-- v If this PR resolves an open issue, please link to it here. For
example, "Fixes sagemath#12345". -->

Fixed sagemath#38960

### 📝 Checklist

<!-- Put an `x` in all the boxes that apply. -->

- [x] The title is concise and informative.
- [x ] The description explains in detail what this PR is about.
- [ x] I have linked a relevant issue or discussion.
- [ ] I have created tests covering the changes.
- [ ] I have updated the documentation and checked the documentation
preview.

### ⌛ Dependencies

<!-- List all open PRs that this PR logically depends on. For example,
-->
<!-- - sagemath#12345: short description why this is a dependency -->
<!-- - sagemath#34567: ... -->
    
URL: sagemath#38962
Reported by: John Cremona
Reviewer(s): Dima Pasechnik
orlitzky pushed a commit to orlitzky/sage that referenced this issue Feb 15, 2025
@JohnCremona @orlitzky
sagemath#38960-eclib-upgrade-20241112
7438eb9
orlitzky pushed a commit to orlitzky/sage that referenced this issue Feb 15, 2025
@JohnCremona @orlitzky
sagemath#38960 fix eclib interface after upgrade
eaef4ae
orlitzky pushed a commit to orlitzky/sage that referenced this issue Feb 15, 2025
@JohnCremona @orlitzky
sagemath#38960 simplify eclib interface
34ffbd9
orlitzky pushed a commit to orlitzky/sage that referenced this issue Feb 15, 2025
@JohnCremona @orlitzky
sagemath#38960: fix lint issue
37aa9f8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JohnCremona JohnCremona

Labels
c: packages: standard dependencies Pull requests that update a dependency file t: enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Upgrade eclib to version 20241112 JohnCremona/sage
1 participant
@JohnCremona