OS X: "make ptestlong" with MAKE set leads to doctest failures in the doctest/ directory #38116
Comments
|
Do the errors show up if you do |
No errors with this; I tried it two or three times and it worked every time. With |
Same thing happens on another machine. |
|
I can't seem to repro this on my machine. Could you post the |
|
Let me revise that: when I run When I run So I see failures, but fewer failures, in one file. |
|
Here is one config.log file: |
|
Could you try with this: diff --git a/src/sage/doctest/control.py b/src/sage/doctest/control.py
index ba78f9bc2a6..fa5b9a062c7 100644
--- a/src/sage/doctest/control.py
+++ b/src/sage/doctest/control.py
@@ -1030,8 +1030,8 @@ class DocTestController(SageObject):
sage: DC = DocTestController(DD, [dirname])
sage: DC.expand_files_into_sources()
sage: for i, source in enumerate(DC.sources):
- ....: DC.stats[source.basename] = {'walltime': 0.1*(i+1)}
- sage: DC.stats['sage.doctest.control'] = {'failed':True,'walltime':1.0}
+ ....: DC.stats[source.basename] = {'walltime': 0.1r*(i+1)}
+ sage: DC.stats['sage.doctest.control'] = {'failed':True,'walltime':1.0r}
sage: DC.filter_sources()
Only doctesting files that failed last test.
sage: len(DC.sources)
@@ -1061,7 +1061,7 @@ class DocTestController(SageObject):
sage: DC.expand_files_into_sources()
sage: DC.sources.sort(key=lambda s:s.basename)
sage: for i, source in enumerate(DC.sources):
- ....: DC.stats[source.basename] = {'walltime': 0.1*(i+1)}
+ ....: DC.stats[source.basename] = {'walltime': 0.1r*(i+1)}
sage: DC.sort_sources()
Sorting sources by runtime so that slower doctests are run first....
sage: print("\n".join(source.basename for source in DC.sources))
@@ -1202,7 +1202,7 @@ class DocTestController(SageObject):
sage: DC.sources.sort(key=lambda s:s.basename)
sage: for i, source in enumerate(DC.sources):
- ....: DC.stats[source.basename] = {'walltime': 0.1*(i+1)}
+ ....: DC.stats[source.basename] = {'walltime': 0.1r*(i+1)}
....:
sage: DC.run() |
|
I get so a slight improvement. |
|
By the way, I think I have been seeing these failures for a long time, both on an Intel machine (which I no longer own) and Apple Silicon. |
|
I've found a few places more to change, please try #38122 |
jhpalmieri
changed the title
|
For what it's worth, I did |
|
Could you check if |
Yes, that fixes it: |
|
Could you try with |
|
I didn't undo the uninstallation of |
sagemathgh-38122: `sage.doctest.control`: In doctests, use Python floats for stats <!-- ^ Please provide a concise and informative title. --> <!-- ^ Don't put issue numbers in the title, do this in the PR description below. --> <!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method to calculate 1 + 2". --> <!-- v Describe your changes below in detail. --> <!-- v Why is this change required? What problem does it solve? --> <!-- v If this PR resolves an open issue, please link to it here. For example, "Fixes sagemath#12345". --> Hopefully fixes sagemath#38116 @jhpalmieri ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [x] The title is concise and informative. - [ ] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on. For example, --> <!-- - sagemath#12345: short description why this is a dependency --> <!-- - sagemath#34567: ... --> URL: sagemath#38122 Reported by: Matthias Köppe Reviewer(s):
sagemathgh-38122: `sage.doctest.control`: In doctests, use Python floats for stats <!-- ^ Please provide a concise and informative title. --> <!-- ^ Don't put issue numbers in the title, do this in the PR description below. --> <!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method to calculate 1 + 2". --> <!-- v Describe your changes below in detail. --> <!-- v Why is this change required? What problem does it solve? --> <!-- v If this PR resolves an open issue, please link to it here. For example, "Fixes sagemath#12345". --> Hopefully fixes sagemath#38116 @jhpalmieri ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [x] The title is concise and informative. - [ ] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on. For example, --> <!-- - sagemath#12345: short description why this is a dependency --> <!-- - sagemath#34567: ... --> URL: sagemath#38122 Reported by: Matthias Köppe Reviewer(s):
sagemathgh-38122: `sage.doctest.control`: In doctests, use Python floats for stats <!-- ^ Please provide a concise and informative title. --> <!-- ^ Don't put issue numbers in the title, do this in the PR description below. --> <!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method to calculate 1 + 2". --> <!-- v Describe your changes below in detail. --> <!-- v Why is this change required? What problem does it solve? --> <!-- v If this PR resolves an open issue, please link to it here. For example, "Fixes sagemath#12345". --> Hopefully fixes sagemath#38116 @jhpalmieri ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [x] The title is concise and informative. - [ ] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on. For example, --> <!-- - sagemath#12345: short description why this is a dependency --> <!-- - sagemath#34567: ... --> URL: sagemath#38122 Reported by: Matthias Köppe Reviewer(s):
sagemathgh-38122: `sage.doctest.control`: In doctests, use Python floats for stats <!-- ^ Please provide a concise and informative title. --> <!-- ^ Don't put issue numbers in the title, do this in the PR description below. --> <!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method to calculate 1 + 2". --> <!-- v Describe your changes below in detail. --> <!-- v Why is this change required? What problem does it solve? --> <!-- v If this PR resolves an open issue, please link to it here. For example, "Fixes sagemath#12345". --> Hopefully fixes sagemath#38116 @jhpalmieri ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [x] The title is concise and informative. - [ ] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on. For example, --> <!-- - sagemath#12345: short description why this is a dependency --> <!-- - sagemath#34567: ... --> URL: sagemath#38122 Reported by: Matthias Köppe Reviewer(s):
|
#38122 fixes a different issue, not this one, so I'm reopening this. |
|
Right, I need to be more careful with the closing references... |
|
For what it's worth, if I disable the |
Steps To Reproduce
With a number of
homebrewpackages in place, and withexport MAKE="make -j8", run./configureandmake ptestlong.Expected Behavior
All tests should pass.
Actual Behavior
I get doctest failures:
and
Additional Information
Note that
./sage -tp --long src/sage/doctest/succeeds: I only see these tests when usingmake ptestlong, and I see them every time.In addition, if
MAKEandMAKEFLAGSare unset, then I do not see these failures withmake ptestlong.Environment
Checklist
The text was updated successfully, but these errors were encountered: