-
-
Notifications
You must be signed in to change notification settings - Fork 554
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update nauty to version 2.8.6 #36257
Milestone
Comments
vbraun
pushed a commit
to vbraun/sage
that referenced
this issue
Oct 28, 2023
sagemathgh-36541: `build/pkgs/nauty`: Upgrade to 2.8.6, require nauty >= 2.8 <!-- ^^^^^ Please provide a concise, informative and self-explanatory title. Don't put issue numbers in there, do this in the PR body below. For example, instead of "Fixes sagemath#1234" use "Introduce new method to calculate 1+1" --> <!-- Describe your changes here in detail --> <!-- Why is this change required? What problem does it solve? --> https://pallini.di.uniroma1.it/changes24-28.txt <!-- If this PR resolves an open issue, please link to it here. For example "Fixes sagemath#12345". --> Fixes sagemath#36257. Continuation of sagemath#36262 We also tighten what versions of system nauty that we accept, because sagemath#36257 was motivated by a new feature. This change should also fix failures from accepting ancient versions of system nauty, such as - `ubuntu-xenial-toolchain-gcc_9` https://github.com/mkoeppe/sage/action s/runs/6622955701/job/18026345225#step:10:7570 in src/sage/graphs/digraph_generators.py and other files <!-- If your change requires a documentation PR, please link it appropriately. --> ### :memo: Checklist <!-- Put an `x` in all the boxes that apply. --> <!-- If your change requires a documentation PR, please link it appropriately --> <!-- If you're unsure about any of these, don't hesitate to ask. We're here to help! --> <!-- Feel free to remove irrelevant items. --> - [x] The title is concise, informative, and self-explanatory. - [ ] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation accordingly. ### :hourglass: Dependencies <!-- List all open PRs that this PR logically depends on - sagemath#12345: short description why this is a dependency - sagemath#34567: ... --> <!-- If you're unsure about any of these, don't hesitate to ask. We're here to help! --> URL: sagemath#36541 Reported by: Matthias Köppe Reviewer(s): David Coudert
vbraun
pushed a commit
to vbraun/sage
that referenced
this issue
Oct 29, 2023
sagemathgh-36541: `build/pkgs/nauty`: Upgrade to 2.8.6, require nauty >= 2.8 <!-- ^^^^^ Please provide a concise, informative and self-explanatory title. Don't put issue numbers in there, do this in the PR body below. For example, instead of "Fixes sagemath#1234" use "Introduce new method to calculate 1+1" --> <!-- Describe your changes here in detail --> <!-- Why is this change required? What problem does it solve? --> https://pallini.di.uniroma1.it/changes24-28.txt <!-- If this PR resolves an open issue, please link to it here. For example "Fixes sagemath#12345". --> Fixes sagemath#36257. Continuation of sagemath#36262 We also tighten what versions of system nauty that we accept, because sagemath#36257 was motivated by a new feature. This change should also fix failures from accepting ancient versions of system nauty, such as - `ubuntu-xenial-toolchain-gcc_9` https://github.com/mkoeppe/sage/action s/runs/6622955701/job/18026345225#step:10:7570 in src/sage/graphs/digraph_generators.py and other files <!-- If your change requires a documentation PR, please link it appropriately. --> ### :memo: Checklist <!-- Put an `x` in all the boxes that apply. --> <!-- If your change requires a documentation PR, please link it appropriately --> <!-- If you're unsure about any of these, don't hesitate to ask. We're here to help! --> <!-- Feel free to remove irrelevant items. --> - [x] The title is concise, informative, and self-explanatory. - [ ] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation accordingly. ### :hourglass: Dependencies <!-- List all open PRs that this PR logically depends on - sagemath#12345: short description why this is a dependency - sagemath#34567: ... --> <!-- If you're unsure about any of these, don't hesitate to ask. We're here to help! --> URL: sagemath#36541 Reported by: Matthias Köppe Reviewer(s): David Coudert
vbraun
pushed a commit
to vbraun/sage
that referenced
this issue
Oct 29, 2023
sagemathgh-36541: `build/pkgs/nauty`: Upgrade to 2.8.6, require nauty >= 2.8 <!-- ^^^^^ Please provide a concise, informative and self-explanatory title. Don't put issue numbers in there, do this in the PR body below. For example, instead of "Fixes sagemath#1234" use "Introduce new method to calculate 1+1" --> <!-- Describe your changes here in detail --> <!-- Why is this change required? What problem does it solve? --> https://pallini.di.uniroma1.it/changes24-28.txt <!-- If this PR resolves an open issue, please link to it here. For example "Fixes sagemath#12345". --> Fixes sagemath#36257. Continuation of sagemath#36262 We also tighten what versions of system nauty that we accept, because sagemath#36257 was motivated by a new feature. This change should also fix failures from accepting ancient versions of system nauty, such as - `ubuntu-xenial-toolchain-gcc_9` https://github.com/mkoeppe/sage/action s/runs/6622955701/job/18026345225#step:10:7570 in src/sage/graphs/digraph_generators.py and other files <!-- If your change requires a documentation PR, please link it appropriately. --> ### :memo: Checklist <!-- Put an `x` in all the boxes that apply. --> <!-- If your change requires a documentation PR, please link it appropriately --> <!-- If you're unsure about any of these, don't hesitate to ask. We're here to help! --> <!-- Feel free to remove irrelevant items. --> - [x] The title is concise, informative, and self-explanatory. - [ ] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation accordingly. ### :hourglass: Dependencies <!-- List all open PRs that this PR logically depends on - sagemath#12345: short description why this is a dependency - sagemath#34567: ... --> <!-- If you're unsure about any of these, don't hesitate to ask. We're here to help! --> URL: sagemath#36541 Reported by: Matthias Köppe Reviewer(s): David Coudert
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Problem Description
nauty 2.8.6 was released almost a year ago, but Sage still uses version 2.7.x
Proposed Solution
Please update the nauty package in Sage to the current version, and update Sage's interface to support the newly added options for
geng
.Alternatives Considered
N/A
Additional Information
No response
Is there an existing issue for this?
The text was updated successfully, but these errors were encountered: