Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

accept fricas from the system #35837

Closed
1 task done
dimpase opened this issue Jun 26, 2023 · 1 comment · Fixed by #35838
Closed
1 task done

accept fricas from the system #35837

dimpase opened this issue Jun 26, 2023 · 1 comment · Fixed by #35838
Assignees
@dimpase
Labels
c: build: configure t: enhancement
Milestone
sage-10.3

Comments

@dimpase
Copy link
Member

dimpase commented Jun 26, 2023 •
edited
Loading

Is there an existing issue for this?

  • I have searched the existing issues for a bug report that matches the one I want to file, without success.

Problem Description

system-wide fricas is sometimes avaliable, and may be used instead of Sage-built one.

Proposed Solution

create spkg-configure for it
@dimpase dimpase self-assigned this Jun 26, 2023
This was referenced Jun 26, 2023
Open
Merged
@slel
Copy link
Member

slel commented Jun 26, 2023

From a discussion on fricas-devel:

vbraun pushed a commit to vbraun/sage that referenced this issue Dec 4, 2023
b84c6b1 
sagemathgh-35838: FriCAS spkg-configure and Feature
    
As FriCAS is only used as an executable, this is straightforward; quite
a number of systems has Fricas 1.3.8, so this is useful, too.

The FriCAS pexpect interface now uses the new `Executable` feature to
determine the absolute pathname of the fricas executable (unless
executed remotely).
This is made possible by a simple refactor of the
`sage.interfaces.expect.Expect` class: Computing the effective command
line is no longer done in `set_server_and_command` (called by
`__init__`); it is delayed until an interface is started and needs the
command line.

- Fixes sagemath#35837
- Fixes sagemath#33575

Dependencies: The changes in `sage.interfaces` outside of `.expect` and
`.fricas` are all from the following PR and do not need review.

- Depends on sagemath#36656 (merged here)
    
URL: sagemath#35838
Reported by: Dima Pasechnik
Reviewer(s): Dima Pasechnik, François Bissey, Matthias Köppe
@vbraun vbraun closed this as completed in 9c4fc77 Dec 6, 2023
@mkoeppe mkoeppe added this to the sage-10.3 milestone Dec 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dimpase dimpase

Labels
c: build: configure t: enhancement
Projects
None yet
Milestone
sage-10.3
Development

Successfully merging a pull request may close this issue.

FriCAS spkg-configure and Feature dimpase/sage
3 participants
@dimpase @slel @mkoeppe