Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sage.{topology,homology}: Replace imports from sage.*.all for namespace packages #34953

Closed
mkoeppe opened this issue Jan 29, 2023 · 6 comments · Fixed by #35098
Closed

sage.{topology,homology}: Replace imports from sage.*.all for namespace packages #34953

mkoeppe opened this issue Jan 29, 2023 · 6 comments · Fixed by #35098
Labels
p: major / 3 t: enhancement t: refactoring
Milestone
sage-10.0

Comments

@mkoeppe
Copy link
Contributor

mkoeppe commented Jan 29, 2023 •
edited
Loading

Using ./sage -fiximports from #34945.

Also remove trailing whitespace in the affected files.

Part of Meta-ticket #34201

CC: @alexchandler100 @jhpalmieri

Component: refactoring

Author: Alex Chandler

Issue created by migration from https://trac.sagemath.org/ticket/34953
@mkoeppe mkoeppe added this to the sage-9.8 milestone Jan 29, 2023
@mkoeppe
Copy link
Contributor Author

mkoeppe commented Jan 29, 2023

Branch: u/mkoeppe/sage__topology_homology___replace_imports_from_sage___all_for_namespace_packages

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Jan 29, 2023

New commits:

301a0d1sage -fiximports src/sage/{topology,homology}

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Jan 29, 2023

Commit: 301a0d1

@mkoeppe mkoeppe modified the milestones: sage-9.8, sage-9.9 Jan 29, 2023
@jhpalmieri
Copy link
Member

This looks good to me. I don't see a pull request attached to it, so do I need to create one, or somehow link to the existing branch and/or commit?

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Feb 8, 2023

Thanks!

I think @vbraun will be able to merge the positively reviewed issues with attached branches.

mkoeppe added a commit to mkoeppe/sage that referenced this issue Feb 12, 2023
@mkoeppe
Merge sagemath#34953
031ebaa
@mkoeppe
Copy link
Contributor Author

mkoeppe commented Feb 13, 2023

Removed branch from the issue description; replaced by PR #35098

vbraun pushed a commit that referenced this issue Mar 19, 2023
2f2ed01 
gh-35098: sage.{topology,homology}: Replace imports from sage.*.all for namespace packages
    
<!-- ^^^^^
Please provide a concise, informative and self-explanatory title.
Don't put issue numbers in there, do this in the PR body below.
For example, instead of "Fixes #1234" use "Introduce new method to
calculate 1+1"
-->
### 📚 Description

<!-- Describe your changes here in detail -->
<!-- Why is this change required? What problem does it solve? -->
<!-- If it resolves an open issue, please link to the issue here. For
example "Closes #1337" -->
Fixes #34953

### 📝 Checklist

<!-- Put an `x` in all the boxes that apply. -->
<!-- If your change requires a documentation PR, please link it
appropriately -->
<!-- If you're unsure about any of these, don't hesitate to ask. We're
here to help! -->

- [x] I have made sure that the title is self-explanatory and the
description concisely explains the PR.
- [x] I have linked an issue or discussion.
- [ ] I have created tests covering the changes.
- [ ] I have updated the documentation accordingly.

### ⌛ Dependencies
<!-- List all open pull requests that this PR logically depends on -->
<!--
- #xyz: short description why this is a dependency
- #abc: ...
-->
    
URL: #35098
Reported by: Matthias Köppe
Reviewer(s):
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
p: major / 3 t: enhancement t: refactoring
Projects
None yet
Milestone
sage-10.0
Development

Successfully merging a pull request may close this issue.

sage.{topology,homology}: Replace imports from sage.*.all for namespace packages mkoeppe/sage
2 participants
@jhpalmieri @mkoeppe