Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sagemath-standard: Add missing dependency typing_extensions, set lower bounds for backport packages #34831

Closed
mkoeppe opened this issue Dec 8, 2022 · 17 comments · Fixed by #35203
Closed

sagemath-standard: Add missing dependency typing_extensions, set lower bounds for backport packages #34831

mkoeppe opened this issue Dec 8, 2022 · 17 comments · Fixed by #35203
Labels
c: build p: major / 3 t: bug
Milestone
sage-10.0

Comments

@mkoeppe
Copy link
Contributor

mkoeppe commented Dec 8, 2022 •
edited
Loading

Used in src/sage/dynamics/arithmetic_dynamics/projective_ds.py.

We also set lower version bounds for backport packages importlib_resources, importlib_metadata, typing_extensions so that Sage developers can use Python 3.11 features.

CC: @kwankyu @EnderWannabe @tobiasdiez

Component: build

Author: Matthias Koeppe

Issue created by migration from https://trac.sagemath.org/ticket/34831
@mkoeppe mkoeppe added this to the sage-9.8 milestone Dec 8, 2022
@mkoeppe
Copy link
Contributor Author

mkoeppe commented Dec 8, 2022

Branch: u/mkoeppe/sagemath_standard__add_missing_dependency_typing_extensions

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Dec 8, 2022

Commit: 4e48354

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Dec 8, 2022

comment:2

Actually the import seems unused in that file, but it's good to have this backport package as a dependency as preparation for more type annotations.

New commits:

4e48354sagelib: Add typing_extensions as a dependency

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Dec 8, 2022

Author: Matthias Koeppe

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Dec 8, 2022

Changed commit from 4e48354 to 10dbc18

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Dec 8, 2022

Branch pushed to git repo; I updated commit sha1. New commits:

10dbc18src/doc/en/developer/coding_in_python.rst: Mention typing_extensions

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Dec 8, 2022

Changed commit from 10dbc18 to b9ac6a2

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Dec 8, 2022

Branch pushed to git repo; I updated commit sha1. New commits:

b9ac6a2sagelib: Add importlib_metadata, importlib_resources as dependencies

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Dec 8, 2022

Branch pushed to git repo; I updated commit sha1. New commits:

d5c0748build/pkgs/{importlib_metadata,importlib_resources,typing_extensions}/install-requires.txt: Set lower bounds for Python 3.11 features

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Dec 8, 2022

Changed commit from b9ac6a2 to d5c0748

@mkoeppe

This comment has been minimized.

Sign in to view
@mkoeppe mkoeppe changed the title sagemath-standard: Add missing dependency typing_extensions sagemath-standard: Add missing dependency typing_extensions, set lower bounds for backport packages Dec 8, 2022
@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Dec 8, 2022

Changed commit from d5c0748 to ecd18a9

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Dec 8, 2022

Branch pushed to git repo; I updated commit sha1. New commits:

ecd18a9src/doc/en/developer/coding_in_python.rst: Fix markup

@EnderWannabe
Copy link
Contributor

comment:9

Replying to Matthias Köppe:

Actually the import seems unused in that file, but it's good to have this backport package as a dependency as preparation for more type annotations.

I can't say I have any idea why I added this import. It seems like it can (and perhaps should) be removed.

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Dec 19, 2022

comment:10

I've opened #34859 to remove it.

@mkoeppe mkoeppe modified the milestones: sage-9.8, sage-9.9 Jan 7, 2023
kryzar pushed a commit to kryzar/sage that referenced this issue Feb 6, 2023
Trac sagemath#34859: sagelib: Remove unnecessary import of typing_ext…
df74efb 
…ensions

see also sagemath#34831

URL: https://trac.sagemath.org/34859
Reported by: mkoeppe
Ticket author(s): Matthias Koeppe
Reviewer(s): John Palmieri
@mkoeppe
Copy link
Contributor Author

mkoeppe commented Feb 12, 2023

Branch has merge conflicts

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Feb 25, 2023

Removed branch from issue description; replaced by PR #35203

vbraun pushed a commit that referenced this issue Mar 26, 2023
e70da89 
gh-35203: sagemath-standard: Add dependencies `typing_extensions`, `importlib_resources`, `importlib_metadata`
    
<!-- ^^^^^
Please provide a concise, informative and self-explanatory title.
Don't put issue numbers in there, do this in the PR body below.
For example, instead of "Fixes #1234" use "Introduce new method to
calculate 1+1"
-->
### 📚 Description

<!-- Describe your changes here in detail -->
<!-- Why is this change required? What problem does it solve? -->
<!-- If it resolves an open issue, please link to the issue here. For
example "Closes #1337" -->
Resolves #34831

### 📝 Checklist

<!-- Put an `x` in all the boxes that apply. -->
<!-- If your change requires a documentation PR, please link it
appropriately -->
<!-- If you're unsure about any of these, don't hesitate to ask. We're
here to help! -->

- [ ] I have made sure that the title is self-explanatory and the
description concisely explains the PR.
- [x] I have linked an issue or discussion.
- [ ] I have created tests covering the changes.
- [ ] I have updated the documentation accordingly.

### ⌛ Dependencies
<!-- List all open pull requests that this PR logically depends on -->
<!--
- #xyz: short description why this is a dependency
- #abc: ...
-->
    
URL: #35203
Reported by: Matthias Köppe
Reviewer(s): Tobias Diez
vbraun pushed a commit to vbraun/sage that referenced this issue Apr 20, 2024
86f18c1 
sagemathgh-37654: Developer guide: Improve discussion of backport packages
    
<!-- ^ Please provide a concise and informative title. -->
<!-- ^ Don't put issue numbers in the title, do this in the PR
description below. -->
<!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method
to calculate 1 + 2". -->
<!-- v Describe your changes below in detail. -->
<!-- v Why is this change required? What problem does it solve? -->
<!-- v If this PR resolves an open issue, please link to it here. For
example, "Fixes sagemath#12345". -->

- sagemath#35203 added these packages as unconditional dependencies
- prompted by a sporadic use of typing_extensions in the Sage library
(see sagemath#34831)
- motivated further by the demand to immediately drop support for Python
3.8 so that newer typing features can be used in the Sage library
(sagemath#35404)
- sagemath#36776 reduced the packages to
conditional dependencies

Here we improve the documentation in the section "Language standard" of
the developer's guide so that it aligns with how the conditional
dependencies are declared.

Based on changes split out from sagemath#37399.

### 📝 Checklist

<!-- Put an `x` in all the boxes that apply. -->

- [ ] The title is concise and informative.
- [ ] The description explains in detail what this PR is about.
- [ ] I have linked a relevant issue or discussion.
- [ ] I have created tests covering the changes.
- [ ] I have updated the documentation accordingly.

### ⌛ Dependencies

<!-- List all open PRs that this PR logically depends on. For example,
-->
<!-- - sagemath#12345: short description why this is a dependency -->
<!-- - sagemath#34567: ... -->
    
URL: sagemath#37654
Reported by: Matthias Köppe
Reviewer(s): Kwankyu Lee, Matthias Köppe
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: build p: major / 3 t: bug
Projects
None yet
Milestone
sage-10.0
2 participants
@mkoeppe @EnderWannabe