Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

log_embedding for number field elements #34212

Closed
guojing0 opened this issue Jul 22, 2022 · 42 comments
Closed

log_embedding for number field elements #34212

guojing0 opened this issue Jul 22, 2022 · 42 comments
Labels
c: number fields p: trivial / 5 t: enhancement
Milestone
sage-9.8

Comments

@guojing0
Copy link
Contributor

This ticket is to add log_embedding (logarithmic embedding) functionality for number field elements, which is then used in #32686 for implementing points_of_bounded_height.

CC: @bhutz @EnderWannabe

Component: number fields

Keywords: gsoc2022

Author: Jing Guo

Branch/Commit: 03aabf5

Reviewer: Alexander Galarraga

Issue created by migration from https://trac.sagemath.org/ticket/34212
@guojing0 guojing0 added this to the sage-9.7 milestone Jul 22, 2022
@guojing0

This comment has been minimized.

Sign in to view
@guojing0
Copy link
Contributor Author

Branch: u/gh-guojing0/34212_logmap

@guojing0
Copy link
Contributor Author

Commit: 41849f8

@guojing0
Copy link
Contributor Author

New commits:

460d5f534212: log embedding for number field elements
41849f834212: tests and docs

@guojing0 guojing0 changed the title log_map for number field elements log_embedding for number field elements Jul 25, 2022
@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jul 26, 2022

Branch pushed to git repo; I updated commit sha1. New commits:

8cf8e2134212: Remove log embedding from number_field_element.pyx
6a0a90c34212: log embedding in number_field.py
629145f34212: fix doc

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jul 26, 2022

Changed commit from 41849f8 to 629145f

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jul 27, 2022

Branch pushed to git repo; I updated commit sha1. New commits:

6cb6ac834212: remove unused import

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jul 27, 2022

Changed commit from 629145f to 6cb6ac8

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Aug 1, 2022

Changed commit from 6cb6ac8 to 650dd04

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Aug 1, 2022

Branch pushed to git repo; I updated commit sha1. New commits:

650dd0434212: log embedding as a morphism

@mkoeppe
Copy link
Contributor

mkoeppe commented Aug 1, 2022

comment:5

The new methods are not indented correctly, so this cannot build

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Aug 1, 2022

Branch pushed to git repo; I updated commit sha1. New commits:

35d369c34212: fix doc

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Aug 1, 2022

Changed commit from 650dd04 to 35d369c

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Aug 1, 2022

Changed commit from 35d369c to 77c4a98

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Aug 1, 2022

Branch pushed to git repo; I updated commit sha1. New commits:

77c4a9834212 fix doc

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Aug 1, 2022

Changed commit from 77c4a98 to 76ba3fe

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Aug 1, 2022

Branch pushed to git repo; I updated commit sha1. New commits:

76ba3fefix

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Aug 2, 2022

Branch pushed to git repo; I updated commit sha1. New commits:

a03b6acfix

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Aug 2, 2022

Changed commit from 76ba3fe to a03b6ac

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Aug 2, 2022

Changed commit from a03b6ac to baed2b1

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Aug 2, 2022

Branch pushed to git repo; I updated commit sha1. New commits:

baed2b1fix

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Aug 3, 2022

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

570fb63clean-up two files in quadratic forms
2065e01fix another detail in quad. forms
7230bd1Updated [SageMath](../wiki/SageMath) version to 9.7.beta5
71b6f4734212: log embedding for number field

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Aug 3, 2022

Changed commit from baed2b1 to 71b6f47

@guojing0
Copy link
Contributor Author

guojing0 commented Aug 3, 2022

Changed commit from 71b6f47 to 9bb1d9b

@guojing0
Copy link
Contributor Author

guojing0 commented Aug 3, 2022

comment:12

Since there are too many commits on this branch, so I created a new one.

New commits:

9bb1d9b34212: log embedding for number fields

@guojing0
Copy link
Contributor Author

guojing0 commented Aug 3, 2022

Changed branch from u/gh-guojing0/34212_logmap to u/gh-guojing0/34212

@guojing0
Copy link
Contributor Author

guojing0 commented Aug 5, 2022

Changed branch from u/gh-guojing0/34212 to u/gh-guojing0/34212_stable

@guojing0
Copy link
Contributor Author

guojing0 commented Aug 5, 2022

Changed commit from 9bb1d9b to 0462be9

@guojing0
Copy link
Contributor Author

guojing0 commented Aug 5, 2022

New commits:

0462be934212: log embedding for number fields

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Aug 10, 2022

Changed commit from 0462be9 to d086479

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Aug 10, 2022

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

d08647934212: clean version

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Aug 11, 2022

Branch pushed to git repo; I updated commit sha1. New commits:

2e9c42a34212: fix doc
ba8c65834212: fix doc and code

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Aug 11, 2022

Changed commit from d086479 to ba8c658

@EnderWannabe
Copy link
Contributor

comment:16

Two comments:

  • Docbuild fails as [Cohen1993] isn't the reference, it should be [Coh1993].
  • I'd like to see an example with more than two places. One option would be to add the number field defined by x4 - 8x2 + 3, which has four real places, as an example.

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Sep 1, 2022

Branch pushed to git repo; I updated commit sha1. New commits:

f531b9334212: Correct doc and add an example
6fb238734212: log embedding for relative number field

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Sep 1, 2022

Changed commit from ba8c658 to 6fb2387

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Sep 1, 2022

Changed commit from 6fb2387 to 03aabf5

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Sep 1, 2022

Branch pushed to git repo; I updated commit sha1. New commits:

03aabf534212: correct examples

@guojing0
Copy link
Contributor Author

guojing0 commented Sep 1, 2022

comment:19

Thank you, Alex. Log embedding for the relative number field is also supported now.

@mkoeppe
Copy link
Contributor

mkoeppe commented Sep 10, 2022

comment:21

reviewer name

@EnderWannabe
Copy link
Contributor

Reviewer: Alexander Galarraga

@mkoeppe mkoeppe modified the milestones: sage-9.7, sage-9.8 Sep 19, 2022
@vbraun
Copy link
Member

vbraun commented Sep 29, 2022

Changed branch from u/gh-guojing0/34212_stable to 03aabf5

@vbraun vbraun closed this as completed in b47402b Sep 29, 2022
@bhutz bhutz mentioned this issue Oct 16, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: number fields p: trivial / 5 t: enhancement
Projects
None yet
Milestone
sage-9.8
Development

No branches or pull requests
4 participants
@vbraun @guojing0 @mkoeppe @EnderWannabe