Skip to content
This repository was archived by the owner on Jan 30, 2023. It is now read-only.

Commit 8cf8e21

Browse files
committed
34212: Remove log embedding from number_field_element.pyx
1 parent 41849f8 commit 8cf8e21

File tree

1 file changed

+0
-47
lines changed

1 file changed

+0
-47
lines changed

src/sage/rings/number_field/number_field_element.pyx

-47
Original file line numberDiff line numberDiff line change
@@ -4118,53 +4118,6 @@ cdef class NumberFieldElement(FieldElement):
41184118
"""
41194119
return (self.global_height_non_arch(prec)+self.global_height_arch(prec))/self.number_field().absolute_degree()
41204120

4121-
def log_embedding(self, x, prec=53):
4122-
"""
4123-
Return the logarithmic embedding of ``x``.
4124-
4125-
The logarithmic embedding is a tuple of real embeddings and conjugate
4126-
pairs of compelx embeddings.
4127-
4128-
It is defined under Definition 4.9.6 in [Cohen1993]_.
4129-
4130-
INPUT:
4131-
4132-
- ``x`` -- a rational number.
4133-
- ``prec`` -- desired floating point precision.
4134-
4135-
OUTPUT:
4136-
4137-
- a tuple of real numbers.
4138-
4139-
EXAMPLES::
4140-
4141-
sage: K.<a> = NumberField(x^3 + 5)
4142-
sage: f = a^2 - 3
4143-
sage: f.log_embedding(10)
4144-
(2.30258509299405)
4145-
sage: f.log_embedding(0)
4146-
(-1)
4147-
"""
4148-
K = self.base_ring()
4149-
K_embeddings = K.places(prec)
4150-
r1, r2 = K.signature()
4151-
r = r1 + r2 - 1
4152-
4153-
Reals = RealField(prec)
4154-
4155-
if x == 0:
4156-
return vector([-1 for _ in range(r + 1)])
4157-
4158-
x_logs = []
4159-
for i in range(r1):
4160-
sigma = K_embeddings[i]
4161-
x_logs.append(Reals(abs(sigma(x))).log())
4162-
for i in range(r1, r + 1):
4163-
tau = K_embeddings[i]
4164-
x_logs.append(2 * Reals(abs(tau(x))).log())
4165-
4166-
return vector(x_logs)
4167-
41684121
def numerator_ideal(self):
41694122
"""
41704123
Return the numerator ideal of this number field element.

0 commit comments

Comments
 (0)