Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace imports from sage.*.all by more specific imports in combinat #33146

Closed
fchapoton opened this issue Jan 10, 2022 · 20 comments
Closed

Replace imports from sage.*.all by more specific imports in combinat #33146

fchapoton opened this issue Jan 10, 2022 · 20 comments

Comments

@fchapoton
Copy link
Contributor

as it breaks the linter..

Depends on #32989
Depends on #32999
Depends on #33007

CC: @mkoeppe

Component: combinatorics

Author: Frédéric Chapoton

Branch/Commit: 9018e5c

Reviewer: Matthias Koeppe

Issue created by migration from https://trac.sagemath.org/ticket/33146

@fchapoton fchapoton added this to the sage-9.5 milestone Jan 10, 2022
@fchapoton
Copy link
Contributor Author

Commit: 4d5be9a

@fchapoton
Copy link
Contributor Author

New commits:

9b329d5some more specific imports in combinat
4d5be9aa few more precise imports in combinat

@fchapoton
Copy link
Contributor Author

Branch: u/chapoton/33146

@fchapoton

This comment has been minimized.

@mkoeppe
Copy link
Contributor

mkoeppe commented Jan 10, 2022

Dependencies: #32989, #32999, #33007

@mkoeppe
Copy link
Contributor

mkoeppe commented Jan 10, 2022

comment:2

Conflicts with #32999

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jan 11, 2022

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jan 11, 2022

Changed commit from 4d5be9a to 9b329d5

@fchapoton
Copy link
Contributor Author

comment:4

better now ?

@mkoeppe
Copy link
Contributor

mkoeppe commented Jan 11, 2022

comment:5

I see a lot of ...site-packages/sage/sets/non_negative_integers.py:83: UserWarning: Resolving lazy import FacadeSets during startup\n Parent.__init__(self, facade = ZZ, category = InfiniteEnumeratedSets().or_subcategory(category) ) when I test this, haven't seen this before (but I'm testing it on top of some other tickets)

@mkoeppe
Copy link
Contributor

mkoeppe commented Jan 11, 2022

comment:6

Also seen in the patchbot report

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jan 13, 2022

Changed commit from 9b329d5 to 750af3d

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jan 13, 2022

Branch pushed to git repo; I updated commit sha1. New commits:

750af3dmodified imports of NN in combinat

@fchapoton
Copy link
Contributor Author

comment:8

let us try again

@fchapoton
Copy link
Contributor Author

comment:9

green bot, so please review

@mkoeppe
Copy link
Contributor

mkoeppe commented Jan 17, 2022

Reviewer: Matthias Koeppe

@mkoeppe mkoeppe changed the title some more specific imports in combinat Replace imports from sage.*.all by more specific imports in combinat Jan 17, 2022
@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Feb 7, 2022

Branch pushed to git repo; I updated commit sha1 and set ticket back to needs_review. New commits:

9018e5cMerge branch 'u/chapoton/33146' in 9.6.beta0

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Feb 7, 2022

Changed commit from 750af3d to 9018e5c

@fchapoton
Copy link
Contributor Author

comment:13

trivial rebase, setting back to positive

@vbraun
Copy link
Member

vbraun commented Feb 13, 2022

Changed branch from u/chapoton/33146 to 9018e5c

@vbraun vbraun closed this as completed in 9d70f97 Feb 13, 2022
mkoeppe added a commit to mkoeppe/sage that referenced this issue Feb 12, 2023
mkoeppe added a commit to mkoeppe/sage that referenced this issue Feb 12, 2023
mkoeppe added a commit to mkoeppe/sage that referenced this issue Feb 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants