Update topcom to 1.1.2, fix cddlib header search #31531

TOPCOM version 0.17.8 updates to gmp-6.1.1 and current
automake/autoconf initialization. In the previous
version 0.17.7, accidentally a wrong version of gmp
was included. Furthermore, a bug was fixed where
a new[] was not followed by a delete[] but a delete.

slel · 2021-03-23T22:29:07Z

comment:2

For very large problems, one can use Jordan-Joswig-Kastner's
parallel mptopcom which
in addition to TOPCOM,
is based on Polymake
and mts.

mkoeppe · 2021-03-24T02:04:25Z

comment:3

Sage development has entered the release candidate phase for 9.3. Setting a new milestone for this ticket based on a cursory review of ticket status, priority, and last modification date.

mkoeppe · 2021-09-18T01:38:32Z

comment:5

Last package to fix for the cddlib header situation... #29413

slel · 2021-11-12T10:34:30Z

Changed keywords from none to upgrade, topcom

slel · 2021-11-12T10:40:31Z

comment:7

The TOPCOM homepage announces an upcoming new version:

current version is 0.17.8,
improved multi-threaded version 1.0.5 currently in test phase

and also points to MTOPCOM.

kliem · 2021-12-06T10:50:55Z

comment:8

I didn't have any luck with it. I tried to figure it out the entire forenoon, which is way more time then I wanted to spend with it.

Tried to use the check from latte, but it always ends like this:

[topcom-0.17.8-beta.11] checking for CDDLIB >= 093c... configure: headers are not in cddlib/
[topcom-0.17.8-beta.11] configure: headers are not in inclusion directory
[topcom-0.17.8-beta.11] configure: headers are not in cdd/
[topcom-0.17.8-beta.11] not found
[topcom-0.17.8-beta.11] checking for CDDLIB >= 093c... configure: headers are not in cddlib/
[topcom-0.17.8-beta.11] configure: headers are not in inclusion directory
[topcom-0.17.8-beta.11] configure: headers are not in cdd/
[topcom-0.17.8-beta.11] not found
[topcom-0.17.8-beta.11] configure: error: The cddlib headers and library are required for topcom.

Probably didn't have gmp linked in and thus couldn't compile the tests.

I pushed the tries here: https://github.com/kliem/topcom/

All that seems to be needed is to modify lib-src-reg/LPinterface.hh to use #include CDDLIB_SETOPER_H and #include CDDLIB_CDD_H.

Anyway, it seems to be one big mess.

slel · 2022-07-07T14:30:57Z

comment:11

TOPCOM homepage now has TOPCOM 0.17.10, and pre-announces:

improved multi-threaded version 1.0.x currently in test phase

mkoeppe · 2022-09-28T22:47:05Z

comment:16

Upstream topcom still doesn't handle the changed cddlib header locations

[topcom-1.1.1] mv -f .deps/SPXinterface.Tpo .deps/SPXinterface.Po
[topcom-1.1.1] mv -f .deps/QSOinterface.Tpo .deps/QSOinterface.Po
[topcom-1.1.1] In file included from LPinterface.cc:12:
[topcom-1.1.1] ./LPinterface.hh:24:10: fatal error: 'setoper.h' file not found
[topcom-1.1.1] #include "setoper.h"
[topcom-1.1.1]          ^~~~~~~~~~~
[topcom-1.1.1] 1 error generated.
[topcom-1.1.1] make[4]: *** [LPinterface.o] Error 1
[topcom-1.1.1] make[4]: *** Waiting for unfinished jobs....
[topcom-1.1.1] In file included from RegularityCheck.cc:13:
[topcom-1.1.1] In file included from ./RegularityCheck.hh:27:
[topcom-1.1.1] ./LPinterface.hh:24:10: fatal error: 'setoper.h' file not found
[topcom-1.1.1] #include "setoper.h"
[topcom-1.1.1]          ^~~~~~~~~~~
[topcom-1.1.1] 1 error generated.

mkoeppe · 2022-09-29T01:00:53Z

Branch: u/mkoeppe/update_topcom_to_1_1_1__fix_cddlib_header_search

dimpase · 2022-10-03T20:07:06Z

comment:26

Replying to Matthias Köppe:

Upstream confirmed by email that they are not interested in having a github repo.
So I'd suggest that we create a repo for tracking upstream in github.com/sagemath, updating https://github.com/kliem/topcom/

I am not sure whether proper updating makes much sense. It seems topcom underwent a serious rewrite since the last changes in https://github.com/kliem/topcom/, with qiute a bit of C++ and examples added - while changes in https://github.com/kliem/topcom/ were not used.
I sure can overwrite https://github.com/kliem/topcom/ with 1.1.1+my patches, otherwise it looks like too much work for little gain.

dimpase · 2022-10-03T21:00:54Z

Author: Matthias Koeppe, Dima Pasechnik

dimpase · 2022-10-03T21:00:54Z

comment:27

apart from the issue of proper tarball hosting (Rambau asked his IT to look into it), looks good, and works on Linux (and on M1 macOS), with or without cddlib from the system.

sagetrac-git · 2022-10-03T21:36:36Z

Branch pushed to git repo; I updated commit sha1. New commits:

`4270822`	`better download location`

sagetrac-git · 2022-10-03T21:36:36Z

Changed commit from e97a2cd to 4270822

dimpase · 2022-10-03T21:45:09Z

comment:29

automatic downloading should work now, I put the tarball on my pages.

mkoeppe · 2022-10-04T04:31:26Z

comment:30

seems to work on macOS Intel too.

mkoeppe · 2022-10-04T04:31:26Z

Reviewer: ..., Matthias Koeppe

dimpase · 2022-10-13T09:44:13Z

comment:32

topcom 1.1.2 has been released

dimpase · 2022-10-17T12:00:35Z

Changed branch from u/dimpase/update_topcom_to_1_1_1__fix_cddlib_header_search to u/dimpase/update_topcom_to_1_1_2__fix_cddlib_header_search

dimpase · 2022-10-17T12:00:35Z

Changed commit from 4270822 to 779b1df

dimpase · 2022-10-17T12:00:35Z

New commits:

`779b1df`	`update topcom to 1.1.2`

sagetrac-git · 2022-10-18T15:51:26Z

Branch pushed to git repo; I updated commit sha1. New commits:

`e481535`	`reformat doctest`

sagetrac-git · 2022-10-18T15:51:26Z

Changed commit from 779b1df to e481535

dimpase · 2022-10-18T15:56:25Z

comment:36

While our (or any system) cddlib is not thead-safe, TOPCOM interface does not use multithreading, so it can be used as it is. So this can go forward. (TOPCOM bundles an oldish (0.94j) cddlib with multithreading patches).

The next release of cddlib will contain the necessary for multithreading patch, see
cddlib/cddlib@1210faf

mkoeppe · 2022-10-19T00:47:41Z

Changed author from Matthias Koeppe, Dima Pasechnik to Dima Pasechnik

mkoeppe · 2022-10-19T00:47:41Z

Changed reviewer from ..., Matthias Koeppe to Matthias Koeppe

vbraun · 2022-10-23T20:49:35Z

Changed branch from u/dimpase/update_topcom_to_1_1_2__fix_cddlib_header_search to e481535

Regression probably introduced by Trac sagemath#31531: Update topcom to 1.1.2, fix cddlib header search {{{ [topcom-1.1.2] config.status: executing depfiles commands [topcom-1.1.2] configure: WARNING: unrecognized options: --with-gmp, --with-cdd [topcom-1.1.2] CDPATH="${ZSH_VERSION+.}:" && cd . && /bin/bash /var/lib/ buildbot/slave/sage_git/build/local/var/tmp/sage/build/topcom-1.1.2/src/ missing aclocal-1.16 [topcom-1.1.2] /var/lib/buildbot/slave/sage_git/build/local/var/tmp/sage /build/topcom-1.1.2/src/missing: line 81: aclocal-1.16: command not found [topcom-1.1.2] WARNING: 'aclocal-1.16' is missing on your system. [topcom-1.1.2] You should only need it if you modified 'acinclude.m4' or [topcom-1.1.2] 'configure.ac' or m4 files included by 'configure.ac'. [topcom-1.1.2] The 'aclocal' program is part of the GNU Automake package: [topcom-1.1.2] <https://www.gnu.org/software/automake> [topcom-1.1.2] It also requires GNU Autoconf, GNU m4 and Perl in order to run: [topcom-1.1.2] <https://www.gnu.org/software/autoconf> [topcom-1.1.2] <https://www.gnu.org/software/m4/> [topcom-1.1.2] <https://www.perl.org/> [topcom-1.1.2] Makefile:336: recipe for target 'aclocal.m4' failed [topcom-1.1.2] make[3]: *** [aclocal.m4] Error 127 [topcom-1.1.2] Error building TOPCOM. [topcom-1.1.2] [topcom-1.1.2] real 0m5.408s [topcom-1.1.2] user 0m2.672s [topcom-1.1.2] sys 0m0.512s [topcom-1.1.2] ************************************************************************ [topcom-1.1.2] Error installing package topcom-1.1.2 [topcom-1.1.2] ************************************************************************ [topcom-1.1.2] Please email sage-devel (http://groups.google.com/group /sage-devel) [topcom-1.1.2] explaining the problem and including the log files [topcom-1.1.2] /var/lib/buildbot/slave/sage_git/build/logs/pkgs/topcom-1.1.2.log [topcom-1.1.2] and [topcom-1.1.2] /var/lib/buildbot/slave/sage_git/build/config.log [topcom-1.1.2] Describe your computer, operating system, etc. [topcom-1.1.2] If you want to try to fix the problem yourself, *don't* just cd to [topcom-1.1.2] /var/lib/buildbot/slave/sage_git/build/local/var/tmp/sage /build/topcom-1.1.2 and type 'make' or whatever is appropriate. [topcom-1.1.2] Instead, the following commands setup all environment variables [topcom-1.1.2] correctly and load a subshell for you to debug the error: [topcom-1.1.2] (cd '/var/lib/buildbot/slave/sage_git/build/local/var/t mp/sage/build/topcom-1.1.2' && '/var/lib/buildbot/slave/sage_git/build/sage' --buildsh) [topcom-1.1.2] When you are done debugging, you can type "exit" to leave the subshell. [topcom-1.1.2] ************************************************************************ Makefile:3067: recipe for target 'topcom-SAGE_LOCAL-no-deps' failed make[2]: *** [topcom-SAGE_LOCAL-no-deps] Error 1 Makefile:3067: recipe for target '/var/lib/buildbot/slave/sage_git/build /local/var/lib/sage/installed/topcom-1.1.2' failed make[1]: *** [/var/lib/buildbot/slave/sage_git/build/local/var/lib/sage/ installed/topcom-1.1.2] Error 2 make[1]: Leaving directory '/var/lib/buildbot/slave/sage_git/build/build/make' }}} URL: https://trac.sagemath.org/34729 Reported by: vbraun Ticket author(s): Matthias Koeppe Reviewer(s): Dima Pasechnik

mkoeppe added this to the sage-9.3 milestone Mar 21, 2021

mkoeppe added c: packages: optional labels Mar 21, 2021

mkoeppe modified the milestones: sage-9.3, sage-9.4 Mar 24, 2021

mkoeppe modified the milestones: sage-9.4, sage-9.5 Aug 9, 2021

This comment has been minimized.

Sign in to view

mkoeppe modified the milestones: sage-9.5, sage-9.6 Dec 18, 2021

mkoeppe modified the milestones: sage-9.6, sage-9.7 Mar 5, 2022

mkoeppe modified the milestones: sage-9.7, sage-9.8 Aug 6, 2022

This comment has been minimized.

Sign in to view

slel changed the title ~~Update topcom to 0.17.8, fix cddlib header search~~ Update topcom to 1.1.0, fix cddlib header search Sep 12, 2022

mkoeppe changed the title ~~Update topcom to 1.1.0, fix cddlib header search~~ Update topcom to 1.1.1, fix cddlib header search Sep 28, 2022

This comment has been minimized.

Sign in to view

dimpase added the s: needs review label Oct 3, 2022

dimpase added s: needs work and removed s: needs review labels Oct 13, 2022

dimpase changed the title ~~Update topcom to 1.1.1, fix cddlib header search~~ Update topcom to 1.1.2, fix cddlib header search Oct 14, 2022

dimpase added s: needs review and removed s: needs work labels Oct 18, 2022

mkoeppe added s: positive review and removed s: needs review labels Oct 19, 2022

vbraun removed the s: positive review label Oct 23, 2022

vbraun closed this as completed in 2049b70 Oct 23, 2022

vbraun mentioned this issue Nov 15, 2022

topcom now requires autotools #34729

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update topcom to 1.1.2, fix cddlib header search #31531

Update topcom to 1.1.2, fix cddlib header search #31531

mkoeppe commented Mar 21, 2021

slel commented Mar 23, 2021

slel commented Mar 23, 2021

mkoeppe commented Mar 24, 2021

mkoeppe commented Sep 18, 2021

slel commented Nov 12, 2021

This comment has been minimized.

slel commented Nov 12, 2021

This comment has been minimized.

kliem commented Dec 6, 2021

slel commented Jul 7, 2022

This comment has been minimized.

This comment has been minimized.

mkoeppe commented Sep 28, 2022

mkoeppe commented Sep 29, 2022

dimpase commented Oct 3, 2022

dimpase commented Oct 3, 2022

dimpase commented Oct 3, 2022

sagetrac-git mannequin commented Oct 3, 2022

sagetrac-git mannequin commented Oct 3, 2022

dimpase commented Oct 3, 2022

mkoeppe commented Oct 4, 2022

mkoeppe commented Oct 4, 2022

dimpase commented Oct 13, 2022

dimpase commented Oct 17, 2022

dimpase commented Oct 17, 2022

dimpase commented Oct 17, 2022

sagetrac-git mannequin commented Oct 18, 2022

sagetrac-git mannequin commented Oct 18, 2022

dimpase commented Oct 18, 2022

mkoeppe commented Oct 19, 2022

mkoeppe commented Oct 19, 2022

vbraun commented Oct 23, 2022

Update topcom to 1.1.2, fix cddlib header search #31531

Update topcom to 1.1.2, fix cddlib header search #31531

Comments

mkoeppe commented Mar 21, 2021

slel commented Mar 23, 2021

slel commented Mar 23, 2021

mkoeppe commented Mar 24, 2021

mkoeppe commented Sep 18, 2021

slel commented Nov 12, 2021

This comment has been minimized.

slel commented Nov 12, 2021

This comment has been minimized.

kliem commented Dec 6, 2021

slel commented Jul 7, 2022

This comment has been minimized.

This comment has been minimized.

mkoeppe commented Sep 28, 2022

mkoeppe commented Sep 29, 2022

dimpase commented Oct 3, 2022

dimpase commented Oct 3, 2022

dimpase commented Oct 3, 2022

sagetrac-git mannequin commented Oct 3, 2022

sagetrac-git mannequin commented Oct 3, 2022

dimpase commented Oct 3, 2022

mkoeppe commented Oct 4, 2022

mkoeppe commented Oct 4, 2022

dimpase commented Oct 13, 2022

dimpase commented Oct 17, 2022

dimpase commented Oct 17, 2022

dimpase commented Oct 17, 2022

sagetrac-git mannequin commented Oct 18, 2022

sagetrac-git mannequin commented Oct 18, 2022

dimpase commented Oct 18, 2022

mkoeppe commented Oct 19, 2022

mkoeppe commented Oct 19, 2022

vbraun commented Oct 23, 2022