Bugfix concerning ticket #26421

[soehms]

In #26421 factorization of polynomials has been extended to previously untreated cases in which the polynomial's base ring is an integral domain.
The factorization is done over the field of fraction and excepted if it can be coerced into the base ring itself. Since the method base_change of the class Factorzation doesn't check if the unit of the factorization is coerced to a unit again, this implementation is too vastly:

sage: R.<t> = LaurentPolynomialRing(ZZ)
sage: P.<x> = R[]
sage: f = 2*x + 4
sage: f.is_irreducible()
True
sage: F = f.factor(); F
(2) * (x + 2)
sage: F.unit()
2

CC: @tscrim

Component: commutative algebra

Keywords: factorization, integral domain

Author: Sebastian Oehms

Branch/Commit: a21db27

Reviewer: Travis Scrimshaw

Issue created by migration from https://trac.sagemath.org/ticket/29266

[soehms]

Branch: u/soehms/factorization_integral_domain_29266

[soehms]

Commit: 004c1c4

[soehms]

comment:2

Maybe a better place for the fix would be the method base_change of the class Factorization. But since this leads to the failure of previous doctests (in cases is_unit is not implemented), I preferred the implementation in method factor.

---

New commits:

004c1c4

29266 initial version

[soehms]

Author: Sebastian Oehms

[tscrim]

Reviewer: Travis Scrimshaw

[tscrim]

comment:3

One little change: "coerce" to "convert". If it was a coercion map, then the fact it was a unit must be preserved (as coercions must be morphisms). Once you change that, you can set a positive review.

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

a21db27

29266: correction according to review

[sagetrac-git]

Changed commit from 004c1c4 to a21db27

[soehms]

comment:5

Thanks!

[vbraun]

Changed branch from u/soehms/factorization_integral_domain_29266 to a21db27