Skip to content

SR should not coerce into QQbar #19231

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
dkrenn opened this issue Sep 17, 2015 · 4 comments
Closed

SR should not coerce into QQbar #19231

dkrenn opened this issue Sep 17, 2015 · 4 comments
Labels
c: symbolics r: invalid t: bug

Comments

@dkrenn
Copy link
Contributor

dkrenn commented Sep 17, 2015 

sage: QQbar.has_coerce_map_from(SR)
True

which is wrong.

Component: symbolics

Issue created by migration from https://trac.sagemath.org/ticket/19231
@dkrenn dkrenn added this to the sage-6.9 milestone Sep 17, 2015
@rwst
Copy link
Contributor

rwst commented Sep 18, 2015

comment:1

Isn't this so that QQbar(expression with sqrt) will work?

@dkrenn
Copy link
Contributor Author

dkrenn commented Sep 18, 2015

comment:2

Replying to @rwst:

Isn't this so that QQbar(expression with sqrt) will work?

There cannot be a coercion from SR to QQbar since, for example, QQbar(SR(pi)) or QQbar(SR(e^x)) does not (and cannot) work.

@fchapoton
Copy link
Contributor

comment:3

This is now saying False and doctested in qqbar.py

@fchapoton fchapoton removed this from the sage-6.9 milestone Jun 9, 2019
@slel
Copy link
Member

slel commented Jun 10, 2019

comment:4

Replying to @fchapoton:

This is now saying False and doctested in qqbar.py

For reference, this is since #14485 was merged.

@fchapoton fchapoton mentioned this issue Jul 7, 2023
Merged
5 tasks
vbraun pushed a commit that referenced this issue Jul 9, 2023
eec0b62 
gh-35910: fix some pep8 in symbolic folder
    
<!-- Please provide a concise, informative and self-explanatory title.
-->
<!-- Don't put issue numbers in the title. Put it in the Description
below. -->
<!-- For example, instead of "Fixes #12345", use "Add a new method to
multiply two integers" -->

### 📚 Description

fixes some pycodestyle warnings in the symbolic folder.

also a few details in the code ;

in particular removing a workaround in the subrings of symbolic ring
(#19231 )

<!-- Describe your changes here in detail. -->
<!-- Why is this change required? What problem does it solve? -->
<!-- If this PR resolves an open issue, please link to it here. For
example "Fixes #12345". -->
<!-- If your change requires a documentation PR, please link it
appropriately. -->

### 📝 Checklist

<!-- Put an `x` in all the boxes that apply. It should be `[x]` not `[x
]`. -->

- [x] The title is concise, informative, and self-explanatory.
- [x] The description explains in detail what this PR is about.
- [ ] I have linked a relevant issue or discussion.
- [ ] I have created tests covering the changes.
- [ ] I have updated the documentation accordingly.

### ⌛ Dependencies

<!-- List all open PRs that this PR logically depends on
- #12345: short description why this is a dependency
- #34567: ...
-->

<!-- If you're unsure about any of these, don't hesitate to ask. We're
here to help! -->
    
URL: #35910
Reported by: Frédéric Chapoton
Reviewer(s): Matthias Köppe
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: symbolics r: invalid t: bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@rwst @slel @fchapoton @dkrenn