Skip to content

Add a polytope tutorial #17247

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
kcrisman opened this issue Oct 28, 2014 · 41 comments
Closed

Add a polytope tutorial #17247

kcrisman opened this issue Oct 28, 2014 · 41 comments

Comments

@kcrisman
Copy link
Member

A Sage user has been kind enough to write a polytopes tutorial. Here it is!

Component: geometry

Keywords: thematic tutorials

Author: sarah-marie belcastro, Karl-Dieter Crisman

Branch: 3124458

Reviewer: Karl-Dieter Crisman, Frédéric Chapoton

Issue created by migration from https://trac.sagemath.org/ticket/17247

@kcrisman kcrisman added this to the sage-6.4 milestone Oct 28, 2014
@kcrisman
Copy link
Member Author

Commit: 8fcca03

@kcrisman
Copy link
Member Author

comment:1

This is a first-time contributor, so in this case any suggestions about formatting etc. would be best handled by just continuing the branch.


New commits:

f3c5c3dAdded polytopes tutorial to thematic tutorials
8fcca03Added polytope tutorial to list of tutorials

@kcrisman
Copy link
Member Author

Branch: u/kcrisman/polytopetut

@kcrisman
Copy link
Member Author

comment:2

Also, I didn't do a lot of editing here, but did remove references to images since they were standard plots, so there may be some Sphinx issues - but I hope not.

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Oct 28, 2014

Changed commit from 8fcca03 to 223590a

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Oct 28, 2014

Branch pushed to git repo; I updated commit sha1. New commits:

223590apartial fix to sphinx issue

@kcrisman
Copy link
Member Author

comment:4

There are still some very minor Sphinx things about a link and the toc tree but I think a review is still in order, as they can be dealt with after content.

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Oct 29, 2014

Branch pushed to git repo; I updated commit sha1. New commits:

f739a3bMake polytope tutorial doc build correctly

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Oct 29, 2014

Changed commit from 223590a to f739a3b

@kcrisman
Copy link
Member Author

comment:6

Okay, now this is 100% ready for review!

@kcrisman
Copy link
Member Author

Changed author from sarah-marie belcastro to sarah-marie belcastro, Karl-Dieter Crisman

@kcrisman
Copy link
Member Author

Changed keywords from none to thematic tutorials

@fchapoton
Copy link
Contributor

comment:7

Could you please use the new style of doctest continuation, namely ....: instead of ... ?

@kcrisman
Copy link
Member Author

kcrisman commented Nov 4, 2014

comment:8

Could you please use the new style of doctest continuation, namely ....: instead of ... ?

Ah, this is just what came out of sws2rst, I don't think I was more than dimly aware of that.

Why don't you take a look at the rest of the content or whatever (pass doctests?) and once you have all things to fix, I'll do them all at once.

@fchapoton
Copy link
Contributor

comment:9

Hello,

I made a reviewer commit. There remains a problem with the schlegel projection (near then end) which is deprecated. This needs to be changed.


New commits:

300e90eMerge branch 'u/kcrisman/polytopetut' of trac.sagemath.org:sage into 17247
8a089aatrac #17247 reviewer commit

@fchapoton
Copy link
Contributor

Changed branch from u/kcrisman/polytopetut to public/ticket/17247

@fchapoton
Copy link
Contributor

Changed commit from f739a3b to 8a089aa

@kcrisman
Copy link
Member Author

kcrisman commented Nov 4, 2014

comment:10

Thanks for the review, very helpful.

As it happens, the author actually always spells her name without capital letters, so I'll change that when I get around to fixing the Schlegel piece - I think it's the show() that is deprecated, not the projection. In fact, this was apparently not doctested at #16625

+    def show(self, *args, **kwds):
+        from sage.misc.superseded import deprecation
+        deprecation(16625, 'use Projection.plot instead')
+        return self.plot(*args, **kwds)

so I may need to fix that as well for this ticket.

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Nov 4, 2014

Branch pushed to git repo; I updated commit sha1. New commits:

f633d82Fix schlegel plot show

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Nov 4, 2014

Changed commit from 8a089aa to f633d82

@kcrisman
Copy link
Member Author

kcrisman commented Nov 4, 2014

comment:12

Okay, this commit should take care of the docs; I assume they look fine built, no other missing double colons or something? Thanks for catching the LaTeX things!

I will do one more commit to add the doctest that should have been added before.

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Nov 4, 2014

Changed commit from f633d82 to 3124458

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Nov 4, 2014

Branch pushed to git repo; I updated commit sha1. New commits:

3124458Add doctest for the deprecation of Projection.show

@kcrisman
Copy link
Member Author

kcrisman commented Nov 4, 2014

comment:14

Okay, hopefully it's good this time.

@kcrisman
Copy link
Member Author

kcrisman commented Nov 4, 2014

Changed reviewer from Karl-Dieter Crisman to Karl-Dieter Crisman, Frédéric Chapoton

@fchapoton
Copy link
Contributor

comment:16

Ok, looks good to me.

@vbraun
Copy link
Member

vbraun commented Nov 9, 2014

Changed author from sarah-marie belcastro, Karl-Dieter Crisman to Sarah-Marie Belcastro, Karl-Dieter Crisman

@vbraun
Copy link
Member

vbraun commented Nov 9, 2014

comment:17

I'm capitalizing the author's name, let me know if your real name uses the lower-case spelling...

@vbraun
Copy link
Member

vbraun commented Nov 9, 2014

Changed branch from public/ticket/17247 to 3124458

@kcrisman
Copy link
Member Author

Changed author from Sarah-Marie Belcastro, Karl-Dieter Crisman to sarah-marie belcastro, Karl-Dieter Crisman

@kcrisman
Copy link
Member Author

comment:19

I'm capitalizing the author's name, let me know if your real name uses the lower-case spelling...

Yes, hers definitely does!

@kcrisman
Copy link
Member Author

Changed commit from 3124458 to none

@jdemeyer
Copy link
Contributor

Changed author from sarah-marie belcastro, Karl-Dieter Crisman to Sarah-Marie Belcastro, Karl-Dieter Crisman

@kcrisman
Copy link
Member Author

Changed author from Sarah-Marie Belcastro, Karl-Dieter Crisman to sarah-marie belcastro, Karl-Dieter Crisman

@kcrisman
Copy link
Member Author

comment:21

Doggone it, I had to change that back once already.

@jdemeyer
Copy link
Contributor

comment:22

Sorry, I assumed it was a mistake.

@kcrisman
Copy link
Member Author

comment:23

Yup, understood.

@fchapoton
Copy link
Contributor

Changed author from sarah-marie belcastro, Karl-Dieter Crisman to Sarah-Marie Belcastro, Karl-Dieter Crisman

@kcrisman
Copy link
Member Author

comment:25

Please read comment:19, comment:21 and comment:22

@kcrisman
Copy link
Member Author

Changed author from Sarah-Marie Belcastro, Karl-Dieter Crisman to sarah-marie belcastro, Karl-Dieter Crisman

@fchapoton
Copy link
Contributor

comment:26

oh, shoot. Sorry. I was cleaning our list of authors..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants