-
-
Notifications
You must be signed in to change notification settings - Fork 601
Add a polytope tutorial #17247
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Commit: |
Branch: u/kcrisman/polytopetut |
comment:2
Also, I didn't do a lot of editing here, but did remove references to images since they were standard plots, so there may be some Sphinx issues - but I hope not. |
Branch pushed to git repo; I updated commit sha1. New commits:
|
comment:4
There are still some very minor Sphinx things about a link and the toc tree but I think a review is still in order, as they can be dealt with after content. |
Branch pushed to git repo; I updated commit sha1. New commits:
|
comment:6
Okay, now this is 100% ready for review! |
Changed author from sarah-marie belcastro to sarah-marie belcastro, Karl-Dieter Crisman |
Changed keywords from none to thematic tutorials |
comment:7
Could you please use the new style of doctest continuation, namely |
comment:8
Ah, this is just what came out of sws2rst, I don't think I was more than dimly aware of that. Why don't you take a look at the rest of the content or whatever (pass doctests?) and once you have all things to fix, I'll do them all at once. |
Changed branch from u/kcrisman/polytopetut to public/ticket/17247 |
comment:10
Thanks for the review, very helpful. As it happens, the author actually always spells her name without capital letters, so I'll change that when I get around to fixing the Schlegel piece - I think it's the
so I may need to fix that as well for this ticket. |
Branch pushed to git repo; I updated commit sha1. New commits:
|
comment:12
Okay, this commit should take care of the docs; I assume they look fine built, no other missing double colons or something? Thanks for catching the LaTeX things! I will do one more commit to add the doctest that should have been added before. |
Branch pushed to git repo; I updated commit sha1. New commits:
|
comment:14
Okay, hopefully it's good this time. |
Changed reviewer from Karl-Dieter Crisman to Karl-Dieter Crisman, Frédéric Chapoton |
comment:16
Ok, looks good to me. |
Changed author from sarah-marie belcastro, Karl-Dieter Crisman to Sarah-Marie Belcastro, Karl-Dieter Crisman |
comment:17
I'm capitalizing the author's name, let me know if your real name uses the lower-case spelling... |
Changed branch from public/ticket/17247 to |
Changed author from Sarah-Marie Belcastro, Karl-Dieter Crisman to sarah-marie belcastro, Karl-Dieter Crisman |
comment:19
Yes, hers definitely does! |
Changed commit from |
Changed author from sarah-marie belcastro, Karl-Dieter Crisman to Sarah-Marie Belcastro, Karl-Dieter Crisman |
Changed author from Sarah-Marie Belcastro, Karl-Dieter Crisman to sarah-marie belcastro, Karl-Dieter Crisman |
comment:21
Doggone it, I had to change that back once already. |
comment:22
Sorry, I assumed it was a mistake. |
comment:23
Yup, understood. |
Changed author from sarah-marie belcastro, Karl-Dieter Crisman to Sarah-Marie Belcastro, Karl-Dieter Crisman |
comment:25
Please read comment:19, comment:21 and comment:22 |
Changed author from Sarah-Marie Belcastro, Karl-Dieter Crisman to sarah-marie belcastro, Karl-Dieter Crisman |
comment:26
oh, shoot. Sorry. I was cleaning our list of authors.. |
A Sage user has been kind enough to write a polytopes tutorial. Here it is!
Component: geometry
Keywords: thematic tutorials
Author: sarah-marie belcastro, Karl-Dieter Crisman
Branch:
3124458
Reviewer: Karl-Dieter Crisman, Frédéric Chapoton
Issue created by migration from https://trac.sagemath.org/ticket/17247
The text was updated successfully, but these errors were encountered: