Better plotting for polytopes, re-add projection_direction

[kcrisman]

From this ask.sagemath question, the two following should be different, but aren't.

poly = polytopes.twenty_four_cell()
poly.show()

poly.show(projection_direction=[2,5,11,17])

CC: @dimpase @vbraun @novoselt

Component: geometry

Author: Volker Braun

Branch: bdb1803

Reviewer: Andrey Novoseltsev

Issue created by migration from https://trac.sagemath.org/ticket/16625

[kcrisman]

comment:2

Even P8prime = P8.base_extend(QQ) doesn't seem to have the schlegel method, which is even more perplexing.

[vbraun]

comment:4

Polyhedra have a schlegel_projection method, and not a schlegel method. The internally used Projection class has a schlegel method.

[kcrisman]

comment:5

Polyhedra have a schlegel_projection method, and not a schlegel method. The internally used Projection class has a schlegel method.

Yes, there was some confusion in my mind earlier...

As to your comment on the ask.sagemath question, unfortunately the following is still in the documentation.

sage: poly = polytopes.twenty_four_cell()
sage: poly
A 4-dimensional polyhedron in QQ^4 defined as the convex hull of 24 vertices
sage: poly.show()
sage: poly.show(projection_direction=[2,5,11,17])

So if that is not supposed to be used in that way, it was missed whenever those methods changed. There is also no deprecation information given.

[vbraun]

Branch: u/vbraun/projection_direction_broken_for_polytopes

[vbraun]

Commit: fa898d1

[vbraun]

New commits:

fa898d1

Better plotting of polyhedra

[vbraun]

Author: Volker Braun

[kcrisman]

comment:8

Wow, that is a lot more than need to fix this :-) It's gone beyond what I can comfortably review in a few minutes, but overall the structure, deprecations, and doc look like a big improvement.

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

8a213a7

Make projection objects display as graphics

[sagetrac-git]

Changed commit from fa898d1 to 8a213a7

[sagetrac-git]

Changed commit from 8a213a7 to cf41e5b

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

cf41e5b

Fix deprecations and doctests

[vbraun]

comment:11

anybody feels like reviewing this?

[novoselt]

comment:12

Working on it.

[novoselt]

Reviewer: Andrey Novoseltsev

[novoselt]

Changed branch from u/vbraun/projection_direction_broken_for_polytopes to u/novoselt/projection_direction_broken_for_polytopes

[novoselt]

comment:14

lgtm and works fine!

---

New commits:

bdb1803

Reorder arguments description.

[novoselt]

Changed commit from cf41e5b to bdb1803

[vbraun]

Changed branch from u/novoselt/projection_direction_broken_for_polytopes to bdb1803

[kcrisman]

comment:16

Just FYI, there was no doctesting of

+    def show(self, *args, **kwds):
+        from sage.misc.superseded import deprecation
+        deprecation(16625, 'use Projection.plot instead')
+        return self.plot(*args, **kwds)

followup will be part of #17247.

[kcrisman]

Changed commit from bdb1803 to none