don't use the deprecated 'new' module

[jhpalmieri]

The Python module 'new' is deprecated and has been removed in Python 3.0, so since it's not hard to avoid it, we shouldn't use it. The attached patch removes all imports of 'new', tested with

sage: search_src('import', 'new', whole_word=True)

The file new.py (in SAGE_ROOT/local/lib/python/) contains code like

from types import InstanceType as instance

so we just have to replace

import new
new.instance(...)

with

import types
types.InstanceType(...)

---

Apply

1. attachment: trac_11819_review.patch

to the sage repository

Component: pickling

Keywords: sd35

Author: John Palmieri

Reviewer: Julian Rueth

Merged: sage-5.0.beta1

Issue created by migration from https://trac.sagemath.org/ticket/11819

[jhpalmieri]

comment:1

Attachment: trac_11819-no-new.patch.gz

[saraedum]

comment:2

It appears I added some uses of 'new' in #11716. So your patch doesn't apply anymore. I'm trying to do something about it now.

[saraedum]

Reviewer: Julian Rueth

[saraedum]

comment:3

I made some additional changes. Feel free to set it to positive review if you're ok with these.

[saraedum]

comment:5

Btw. I'll add doctests to the new functions in #12192.

[saraedum]

comment:6

Apply trac_11819_review.patch

[jhpalmieri]

comment:7

The doctest

    sage: sage0("'new' in sys.modules")
    False

fails for me. It might be imported by IPython; if I do sage --ipython:

In [1]: import sys

In [2]: 'new' in sys.modules
Out[2]: True

Or more tersely:

$ sage --ipython -c "import sys; print 'new' in sys.modules"
True

[saraedum]

Attachment: trac_11819_review.patch.gz

combined and rebased patch

[saraedum]

comment:8

You are right. I must have run the wrong patch somehow. Sorry for that.

I adapted my patch. I it works now.

[saraedum]

Changed keywords from none to sd35

[jdemeyer]

Merged: sage-5.0.beta1