Remove twisted.persisted.styles import

[saraedum]

The import of twisted.persisted.styles takes a significant amount of time on sage startup:

$ time ./sage -startuptime|grep twisted.persisted.styles:
 twisted.persisted.styles: 0.093 (sage.all)

real    0m1.422s

Most functionality from that module seems not to be used in sage. The attached patch removes everything but the needed functionality:

$ time ./sage -startuptime|grep twisted.persisted.styles:

real    0m1.280s

---

Apply only attachment: trac_11716_twisted_persisted_styles.proper.patch to the Sage library.

Component: performance

Keywords: sd32 start-up time startup

Author: Julian Rueth

Reviewer: Mike Hansen

Merged: sage-4.7.2.alpha3

Issue created by migration from https://trac.sagemath.org/ticket/11716

[mwhansen]

comment:1

I like the idea of this, but I think that the methods should be moved into say "sage.misc.fpickle" instead of "sage.misc.cachefunc".

[mwhansen]

Reviewer: Mike Hansen

[saraedum]

Attachment: trac_11716_twisted_persisted_styles.patch.gz

[saraedum]

comment:2

Good point. I was actually unsure where to put it. I fixed the patch accordingly. I'm waiting for the doctests to finish now.

[saraedum]

comment:3

Passed the doctests against 4.7.2.alpha2.

[robertwb]

comment:4

That one was at the top of my hit list too--I'm relieved it turned out to be so painless.

[jdemeyer]

comment:5

saraedum: please add your real name as Author on this ticket. It would also be good to put yourself on http://trac.sagemath.org/sage_trac/#AccountNamesMappedtoRealNames.

[williamstein]

Author: Julian Rueth

[williamstein]

comment:7

I added saraedum's real name to the Author on the ticket at the wiki.

[williamstein]

Changed keywords from none to sd32

[nexttime]

Changed keywords from sd32 to sd32 start-up time startup

[nexttime]

Merged: sage-4.7.2.alpha3

[nexttime]

"Proper" Mercurial changeset replacement patch.

[nexttime]

comment:11

Attachment: trac_11716_twisted_persisted_styles.proper.patch.gz

I've attached a *.proper.patch, which is identical except that I removed the "garbage" before "# HG changeset patch", i.e., I deleted the first line "exporting patch:", since Jeroen's current merger rejects such patches.

For now, please make sure all your patches start with "# HG changeset patch", i.e., have it on the first line without any preceding messages or whatever.

I've relaxed that in my version of the merger, but Jeroen and maybe others are likely to use his more restrictive one.