Skip to content

Commit

Permalink
Browse files Browse the repository at this point in the history
gh-35412: Activate codecov reports even if other checks are failing
    
<!-- Please provide a concise, informative and self-explanatory title.
-->
<!-- Don't put issue numbers in the title. Put it in the Description
below. -->
<!-- For example, instead of "Fixes #12345", use "Add a new method to
multiply two integers" -->

### 📚 Description

Follow-up from #35056. Currently no
codecov reports are displayed because the doc deployment workflow is
failing and codecov by default only adds its checks if all other checks
are passing. We change this setting so that codecov checks are always
added, regardless of other failing tests.

<!-- Describe your changes here in detail. -->
<!-- Why is this change required? What problem does it solve? -->
<!-- If this PR resolves an open issue, please link to it here. For
example "Fixes #12345". -->
<!-- If your change requires a documentation PR, please link it
appropriately. -->

### 📝 Checklist

<!-- Put an `x` in all the boxes that apply. It should be `[x]` not `[x
]`. -->

- [x] The title is concise, informative, and self-explanatory.
- [x] The description explains in detail what this PR is about.
- [x] I have linked a relevant issue or discussion.
- [ ] I have created tests covering the changes.
- [ ] I have updated the documentation accordingly.

### ⌛ Dependencies

<!-- List all open PRs that this PR logically depends on
- #12345: short description why this is a dependency
- #34567: ...
-->

<!-- If you're unsure about any of these, don't hesitate to ask. We're
here to help! -->
    
URL: #35412
Reported by: Tobias Diez
Reviewer(s): Kwankyu Lee, Matthias Köppe, Tobias Diez
  • Loading branch information
Release Manager committed Apr 4, 2023
2 parents 80ada8e + 3554196 commit 2fc44c9
Showing 1 changed file with 3 additions and 0 deletions.
3 changes: 3 additions & 0 deletions .codecov.yml
Original file line number Diff line number Diff line change
@@ -1,5 +1,8 @@
# https://docs.codecov.com/docs/pull-request-comments#disable-comment
comment: false
# https://docs.codecov.com/docs/codecovyml-reference#codecov
codecov:
require_ci_to_pass: false
# https://docs.codecov.com/docs/commit-status
coverage:
status:
Expand Down

0 comments on commit 2fc44c9

Please sign in to comment.