Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests: Add advanced details tests #4901

Merged
merged 1 commit into from
Feb 6, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions .github/workflows/web-e2e-prod-ondemand.yml
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,6 @@ on:
workflow_dispatch:
schedule:
- cron: '0 4 * * 1-5'
push:
branches:
- main

concurrency:
group: ${{ github.workflow }}-${{ github.ref }}
Expand Down
34 changes: 33 additions & 1 deletion apps/web/cypress/e2e/pages/create_tx.pages.js
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,11 @@ const noteAlert = "[data-testid='tx-note-alert']"
const recoredTxNote = '[data-testid="tx-note"]'
const txNoteTooltip = '[data-testid="tx-note-tooltip"]'
const noteCreator = '[data-testid="note-creator"]'
const tableViewBtn = '[data-testid="table-view-btn"]'
const gridViewBtn = '[data-testid="grid-view-btn"]'
const txHexData = '[data-testid="tx-hex-data"]'
const txStack = '[data-testid="tx-stack"]'
const txOperation = '[data-testid="tx-operation"]'

const viewTransactionBtn = 'View transaction'
const transactionDetailsTitle = 'Transaction details'
Expand Down Expand Up @@ -106,6 +111,11 @@ export const filterTypes = {
module: 'Module-based',
}

export const advancedDetailsViewOptions = {
table: 'table',
grid: 'grid',
}

export function typeNoteText(text) {
cy.get(noteTextField).find('input').clear().type(text)
}
Expand Down Expand Up @@ -373,10 +383,32 @@ export function clickOnAdvancedDetails() {
export function expandAdvancedDetails(data) {
clickOnAdvancedDetails()
data.forEach((row) => {
cy.get(txRowTitle).contains(row).should('be.visible')
cy.get('div').contains(row).should('be.visible')
})
}

export function switchView(view) {
if (view === advancedDetailsViewOptions.table) {
cy.get(tableViewBtn).click()
cy.get(txHexData).should('be.visible')
} else {
cy.get(gridViewBtn).click()
cy.get(txOperation).should('be.visible')
}
}

export function clickOnCopyDataBtn(expectedData) {
cy.get(txStack).find('button').click()
cy.wait(2000)
cy.window().then((win) => {
cy.wrap(win.navigator.clipboard.readText()).should('eq', expectedData)
})
}

export function switchToGridView() {
cy.get(gridViewBtn).click()
}

export function collapseAdvancedDetails() {
clickOnAdvancedDetails()
cy.get(baseGas).should('not.exist')
Expand Down
4 changes: 4 additions & 0 deletions apps/web/cypress/e2e/pages/staking.page.js
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,10 @@ export function getActivationTimeRegex() {
return new RegExp('^\\d+\\s+hour(s)?\\s+\\d+\\s+minute(s)?$')
}

export function checkActivationTimeNonEmpty() {
return new RegExp('.+')
}

export function checkTxHeaderData(data) {
main.verifyValuesExist(create_tx.transactionItem, data)
}
Expand Down
2 changes: 1 addition & 1 deletion apps/web/cypress/e2e/pages/swaps.pages.js
Original file line number Diff line number Diff line change
Expand Up @@ -369,7 +369,7 @@ export function getWidgetFee() {
}

export function getTokenValue() {
return new RegExp(`\\$\\d+\\.\\d{2}`, 'i')
return new RegExp(`\\$\\d+`, 'i')
}

export function checkTokenOrder(regexPattern, option) {
Expand Down
3 changes: 2 additions & 1 deletion apps/web/cypress/e2e/prodhealthcheck/tx_history.cy.js
Original file line number Diff line number Diff line change
Expand Up @@ -119,7 +119,8 @@ describe('[PROD] Tx history tests 1', () => {
])
})

it('Verify advanced details displayed in exapanded details for allowance deletion', () => {
// Unskip when advanced details PR is merged to main
it.skip('Verify advanced details displayed in exapanded details for allowance deletion', () => {
createTx.clickOnTransactionItemByName(typeDeleteAllowance.title, typeDeleteAllowance.summaryTxInfo)
createTx.expandAdvancedDetails([typeDeleteAllowance.baseGas])
createTx.collapseAdvancedDetails([typeDeleteAllowance.baseGas])
Expand Down
2 changes: 1 addition & 1 deletion apps/web/cypress/e2e/regression/staking_history.cy.js
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ describe('Staking history tests', { defaultCommandTimeout: 30000 }, () => {
staking.checkDataFields(staking.dataFields.netMonthlyRewards, staking.getRewardRegex())
staking.checkDataFields(staking.dataFields.fee, staking.getPercentageRegex())
staking.checkDataFields(staking.dataFields.validators, '1')
staking.checkDataFields(staking.dataFields.activationTime, staking.getActivationTimeRegex())
staking.checkDataFields(staking.dataFields.activationTime, staking.checkActivationTimeNonEmpty())
staking.checkDataFields(staking.dataFields.rewards, historyData.rewardsValue)
})
})
18 changes: 16 additions & 2 deletions apps/web/cypress/e2e/regression/tx_history.cy.js
Original file line number Diff line number Diff line change
Expand Up @@ -151,10 +151,24 @@ describe('Tx history tests 1', () => {
])
})

// Added to prod
// Added to prod (skipped)
it('Verify advanced details displayed in exapanded details for allowance deletion', () => {
createTx.clickOnTransactionItemByName(typeDeleteAllowance.title, typeDeleteAllowance.summaryTxInfo)
createTx.expandAdvancedDetails([typeDeleteAllowance.baseGas])
createTx.expandAdvancedDetails([
typeDeleteAllowance.baseGas,
typeDeleteAllowance.operation,
typeDeleteAllowance.zero_call,
])
createTx.switchView(createTx.advancedDetailsViewOptions.table)
createTx.collapseAdvancedDetails([typeDeleteAllowance.baseGas])
})

it('Verify address can be copied in advanced details', () => {
const data =
'0x885133e3000000000000000000000000c16db0251654c0a72e91b190d81ead367d2c6fed0000000000000000000000000000000000000000000000000000000000000000'
createTx.clickOnTransactionItemByName(typeDeleteAllowance.title, typeDeleteAllowance.summaryTxInfo)
createTx.expandAdvancedDetails([typeDeleteAllowance.baseGas])
createTx.switchView(createTx.advancedDetailsViewOptions.table)
createTx.clickOnCopyDataBtn(data)
})
})
4 changes: 3 additions & 1 deletion apps/web/cypress/fixtures/txhistory_data_data.json
Original file line number Diff line number Diff line change
Expand Up @@ -163,7 +163,9 @@
"token": "Token",
"tokenName": "ETH",
"tokenAlt": "ETH",
"baseGas": "baseGas"
"baseGas": "baseGas",
"operation": "Operation",
"zero_call": "0 (call)"
},
"spendingLimits": {
"title": "Batch",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -55,10 +55,10 @@ export const ViewToggleButtonGroup = ({

return (
<StyledToggleButtonGroup size="small" value={value} exclusive onChange={changeView} aria-label="text alignment">
<ToggleButton value={View.Decoded} aria-label="decoded">
<ToggleButton data-testid="grid-view-btn" value={View.Decoded} aria-label="decoded">
<GridViewRoundedIcon />
</ToggleButton>
<ToggleButton value={View.Raw} aria-label="raw">
<ToggleButton data-testid="table-view-btn" value={View.Raw} aria-label="raw">
<TableRowsRoundedIcon />
</ToggleButton>
</StyledToggleButtonGroup>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -144,7 +144,13 @@ export const AdvancedTxDetails = ({
{view === View.Raw && txData.hexData && (
<>
<Stack direction="row" justifyContent="space-between">
<Stack direction="row" spacing={0.5} alignItems="center" height="fit-content">
<Stack
data-testid="tx-stack"
direction="row"
spacing={0.5}
alignItems="center"
height="fit-content"
>
<Typography color="primary.light">Data</Typography>
<CopyButton text={txData.hexData} />
</Stack>
Expand All @@ -153,6 +159,7 @@ export const AdvancedTxDetails = ({
</Stack>

<Typography
data-testid="tx-hex-data"
variant="body2"
color="primary.light"
fontFamily="monospace"
Expand Down
Loading