Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extensible Fallback Handler #851

Merged
merged 3 commits into from
Oct 29, 2024
Merged

Extensible Fallback Handler #851

merged 3 commits into from
Oct 29, 2024

Conversation

remedcu
Copy link
Member

@remedcu remedcu commented Oct 28, 2024 •
edited
Loading

This PR brings the ExtensibleFallbackHandler created here to safe-smart-account repo. Changes taken based on git diff.

Some small changes were made like:

  • Adapting tests to the safe-smart-account repo.
  • Remove unused import.
  • Replace global importing (based on our lint setup) with specific contracts required.

@remedcu remedcu self-assigned this Oct 28, 2024
@remedcu remedcu marked this pull request as ready for review October 28, 2024 13:27
@remedcu remedcu merged commit 76ea23d into main Oct 29, 2024
25 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Oct 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mmv08 mmv08 mmv08 approved these changes

@nlordell nlordell Awaiting requested review from nlordell

@akshay-ap akshay-ap Awaiting requested review from akshay-ap

Assignees

@remedcu remedcu

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@remedcu @mmv08