Feature: bytecode size reduction by removing public getChainId function, making encodeTransactionData private
#603
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmv08
requested review from
a team,
rmeissner,
Uxio0 and
akshay-ap
and removed request for
a team
mmv08
commented
Jul 6, 2023
| @@ -58,13 +58,6 @@ describe("Safe", async () => { | |||
| }); | |||
| }); | |||
|
|
|||
| describe("getChainId", async () => { | |||
There was a problem hiding this comment.
This should be still covered by the domain separator test
Pull Request Test Coverage Report for Build 5473862599
💛 - Coveralls |
rmeissner
approved these changes
Jul 10, 2023
akshay-ap
approved these changes
Jul 10, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a pre-requisite for future 1.5.0 features like the overloaded
checkNSignaturesand the module guard.Code size after all the changes: