Closes #161: Add EIP-165 support in DefaultCallbackHandler #285
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Uxio0
approved these changes
Mar 24, 2021
| { | ||
| return interfaceId == type(ERC1155TokenReceiver).interfaceId | ||
| || interfaceId == type(ERC721TokenReceiver).interfaceId | ||
| || interfaceId == type(IERC165).interfaceId; |
There was a problem hiding this comment.
So I guess this is the same that interfaceId == this.supportsInterface.selector
There was a problem hiding this comment.
I think so yes ... I just went with this as it was more in line we the statements above.
| returns (bool) | ||
| { | ||
| return interfaceId == type(ERC1155TokenReceiver).interfaceId | ||
| || interfaceId == type(ERC721TokenReceiver).interfaceId |
There was a problem hiding this comment.
I didn't know interfaceId was introduced in Solidity some months ago, nice
rmeissner
deleted the
feature/issue_161_erc_165_fallback_handler_support
branch
Uxio0
pushed a commit
that referenced
this pull request
May 6, 2021
Saw-mon-and-Natalie
pushed a commit
to Saw-mon-and-Natalie/safe-contracts
that referenced
this pull request
Nov 1, 2023
fdarian
pushed a commit
to fdarian/safe-contracts
that referenced
this pull request
Jan 14, 2024
…tibility Safe v1.0.0 and v1.1.1 compatibility
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #161