Skip to content

Commit

Permalink
Using harness patch to remove getTransactionHash(...) in ISafe
Browse files Browse the repository at this point in the history
  • Loading branch information
remedcu committed Jan 10, 2024
1 parent ce6e554 commit c46d5bd
Showing 1 changed file with 38 additions and 1 deletion.
39 changes: 38 additions & 1 deletion certora/applyHarness.patch
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ diff -druN Safe.sol Safe.sol
address refundReceiver,
uint256 _nonce
- ) public view override returns (bytes32) {
+ ) internal view override returns (bytes32) {
+ ) internal view returns (bytes32) {
+ // MUNGED: The function was made internal to enable CVL summaries.
return keccak256(encodeTransactionData(to, value, data, operation, safeTxGas, baseGas, gasPrice, gasToken, refundReceiver, _nonce));
}
Expand All @@ -56,3 +56,40 @@ diff -druN base/Executor.sol base/Executor.sol
} else {
/* solhint-disable no-inline-assembly */
/// @solidity memory-safe-assembly
diff -druN interfaces/ISafe.sol interfaces/ISafe.sol
--- interfaces/ISafe.sol 2024-01-10 15:36:01
+++ interfaces/ISafe.sol 2024-01-10 15:55:55
@@ -110,33 +110,6 @@
function domainSeparator() external view returns (bytes32);

/**
- * @notice Returns transaction hash to be signed by owners.
- * @param to Destination address.
- * @param value Ether value.
- * @param data Data payload.
- * @param operation Operation type.
- * @param safeTxGas Gas that should be used for the safe transaction.
- * @param baseGas Gas costs for data used to trigger the safe transaction.
- * @param gasPrice Maximum gas price that should be used for this transaction.
- * @param gasToken Token address (or 0 if ETH) that is used for the payment.
- * @param refundReceiver Address of receiver of gas payment (or 0 if tx.origin).
- * @param _nonce Transaction nonce.
- * @return Transaction hash.
- */
- function getTransactionHash(
- address to,
- uint256 value,
- bytes calldata data,
- Enum.Operation operation,
- uint256 safeTxGas,
- uint256 baseGas,
- uint256 gasPrice,
- address gasToken,
- address refundReceiver,
- uint256 _nonce
- ) external view returns (bytes32);
-
- /**
* @dev External getter function for state variables.
*/
// solhint-disable-next-line

0 comments on commit c46d5bd

Please sign in to comment.