Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[New chain]: Hemi Mainnet #821

Merged
merged 1 commit into from
Dec 9, 2024
Merged

[New chain]: Hemi Mainnet #821

merged 1 commit into from
Dec 9, 2024

Conversation

rokso
Copy link
Contributor

@rokso rokso commented Dec 6, 2024

Fixes #771

Singleton factory is deployed as part of predeploy and hence I am using values from OP chain artifact file.

@rokso rokso requested a review from a team as a code owner December 6, 2024 14:15
@nlordell
Copy link
Collaborator

nlordell commented Dec 9, 2024

Hmm, I'm actually not sure what the transaction and gas fields should be in this case... One issue I have with the current PR is that the signed transaction is not signed for the correct chain ID.

@nlordell
Copy link
Collaborator

nlordell commented Dec 9, 2024

Sorry for the back-and-forth. We discussed internally and proposed the following for networks with pre-installed Safe Singleton Factory contracts:

https://github.com/safe-global/safe-singleton-factory?tab=readme-ov-file#op-stack

@nlordell
Copy link
Collaborator

nlordell commented Dec 9, 2024

Verified deployment code using the RPC from #771 with:

curl -s -X POST $RPC -H 'content-type: application/json' --data '{"jsonrpc":"2.0","id":0,"method":"eth_getCode","params":["0x914d7Fec6aaC8cd542e72Bca78B30650d45643d7","latest"]}' | jq -r .result

And that it is in fact a pre-installed contract (as the signer account has a 0 nonce):

curl -s -X POST $RPC -H 'content-type: application/json' --data '{"jsonrpc":"2.0","id":0,"method":"eth_getTransactionCount","params":["0xE1CB04A0fA36DdD16a06ea828007E35e1a3cBC37","latest"]}' | jq -r .result

@nlordell
Copy link
Collaborator

nlordell commented Dec 9, 2024

Thanks @rokso!

@nlordell nlordell merged commit 36594b0 into safe-global:main Dec 9, 2024
@rokso rokso deleted the hemi-mainnet branch December 9, 2024 19:32
@akshay-ap akshay-ap mentioned this pull request Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[New chain]: Hemi Mainnet
2 participants