Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Certora Script Update & Minor changes #470

Merged
merged 1 commit into from
Jul 22, 2024
Merged

Certora Script Update & Minor changes #470

merged 1 commit into from
Jul 22, 2024

Conversation

remedcu
Copy link
Member

@remedcu remedcu commented Jul 22, 2024

Fixes #468

This PR eliminates the use of a script for the Certora FV and uses the Certora CLI command directly.

In addition, extra small changes included in this PR:

  • Natspec changes in Harness solidity code.
  • Inclusion of Recovery Module in the README.
  • Using the latest version of checkout (v4) for GitHub CI.

@remedcu remedcu self-assigned this Jul 22, 2024
@coveralls
Copy link

Pull Request Test Coverage Report for Build 10037379863

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 10008091065: 0.0%
Covered Lines: 51
Relevant Lines: 51

💛 - Coveralls

@remedcu remedcu marked this pull request as ready for review July 22, 2024 08:45
@remedcu remedcu requested a review from a team as a code owner July 22, 2024 08:45
@remedcu remedcu requested review from nlordell, akshay-ap and mmv08 and removed request for a team July 22, 2024 08:45
@@ -0,0 +1 @@
certora-cli==7.3.0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we switch to latest https://pypi.org/project/certora-cli/ ? would be a good thing to do together with updating the scripts

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As mentioned in today's sync, I will create a new issue for the upgrade as this requires some changes to the specs which I want to discuss with Certora first.

@remedcu remedcu merged commit 78f3239 into main Jul 22, 2024
14 checks passed
@remedcu remedcu deleted the certora-script branch July 22, 2024 12:55
@github-actions github-actions bot locked and limited conversation to collaborators Jul 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Safe Modules Certora Setup Refactor
3 participants