Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Internal Function Naming Convention #171

Merged
merged 2 commits into from
Nov 27, 2023
Merged

Internal Function Naming Convention #171

merged 2 commits into from
Nov 27, 2023

Conversation

nlordell
Copy link
Collaborator

In preparing for the v0.1.1 audit, I noticed we (i.e. me) forgot to follow internal function naming convention for _getOperationData. This PR fixes that (already fixed in the v0.1 branch) and moves the function down closer to the other internal functions.

@nlordell nlordell requested a review from a team as a code owner November 24, 2023 15:49
@nlordell nlordell requested review from rmeissner, akshay-ap, mmv08 and remedcu and removed request for a team November 24, 2023 15:49
@remedcu
Copy link
Member

remedcu commented Nov 24, 2023

Should we also make the change in SafeMock.sol, and change the function name from encodeOperationData(...) to _getOperationData(...) to keep consistency?

@coveralls
Copy link

Pull Request Test Coverage Report for Build 7002940540

  • 3 of 3 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%
Totals Coverage Status
Change from base Build 6979715187: 0.0%
Covered Lines: 29
Relevant Lines: 29
💛 - Coveralls

@nlordell
Copy link
Collaborator Author

@remedcu - implemented your suggestion.

remedcu
remedcu approved these changes Nov 27, 2023
View reviewed changes
Copy link
Member

@remedcu remedcu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏾

@nlordell nlordell merged commit 75e24b9 into master Nov 27, 2023
4 checks passed
@nlordell nlordell deleted the internal-function-naming-again branch November 27, 2023 10:52
@github-actions github-actions bot locked and limited conversation to collaborators Nov 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@remedcu remedcu remedcu approved these changes

@rmeissner rmeissner Awaiting requested review from rmeissner rmeissner was automatically assigned from safe-global/safe-protocol

@akshay-ap akshay-ap Awaiting requested review from akshay-ap akshay-ap was automatically assigned from safe-global/safe-protocol

@mmv08 mmv08 Awaiting requested review from mmv08 mmv08 was automatically assigned from safe-global/safe-protocol

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nlordell @remedcu @coveralls