Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ERC-4337 Bundler Updates #161

Merged
merged 1 commit into from
Nov 22, 2023
Merged

ERC-4337 Bundler Updates #161

merged 1 commit into from
Nov 22, 2023

Conversation

nlordell
Copy link
Collaborator

This PR updates the reference bundler used for E2E tests:

Notice that the E2E test run significantly faster with this change:

# before
  E2E - Local Bundler
    ✔ should deploy a new Safe and execute a transaction (3731ms)
    ✔ should execute a transaction for an exsiting Safe (2880ms)
# after
  E2E - Local Bundler
    ✔ should deploy a new Safe and execute a transaction (912ms)
    ✔ should execute a transaction for an exsiting Safe (628ms)

@nlordell nlordell requested a review from a team as a code owner November 21, 2023 13:25
@nlordell nlordell requested review from rmeissner, akshay-ap, mmv08 and remedcu and removed request for a team November 21, 2023 13:25
WORKDIR /src/bundler
# v0.6.1
RUN git checkout 30dc20da10214415df60a5ee15a6bec0975c9af1
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately, there is no tag - so we use a commit hash.

@nlordell nlordell merged commit 406ef30 into master Nov 22, 2023
@nlordell nlordell deleted the bundler-updates branch November 22, 2023 10:10
@github-actions github-actions bot locked and limited conversation to collaborators Nov 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants