feat: careers benefits #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ESLint Summary View Full Report
Report generated by eslint-plus-action |
iamacook
commented
Feb 8, 2023
Comment on lines
22
to
23
| // Appease ESLint | ||
| const { alt = '', ...rest } = image |
There was a problem hiding this comment.
We're going to get this warning in a few places in this PR as we spread image in a few places.
Shall we disable the linting rule? It currently only warns us.
There was a problem hiding this comment.
I solved the issue and have added comments in the code accordingly.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it solves
Partially resolves #3
How this PR fixes it
The careers page benefits has been implemented according to the design.
A refactored of
UspBlockandBaseBlockis included, adjusting all instances ofimageattributes where necessary.Screenshots