chore: Add Prettier formatter #432
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Overall readability score: 68.28 (🟢 +0)
View detailed metrics🟢 - Shows an increase in readability
Averages:
View metric targets
|
louis-md
requested changes
Apr 11, 2024
| @@ -0,0 +1,7 @@ | |||
| { | |||
| "printWidth": 80, | |||
| "semi": false, | |||
There was a problem hiding this comment.
I'd leave that to true, it might become super confusing when coding with standard.js and then use different rules for code inside markdown
There was a problem hiding this comment.
All the code we have in TypeScript doesn't use semicolons (all the kits in the SDK included)
| @@ -9,6 +9,7 @@ | |||
| "validate-resources": "node .github/scripts/validateResources.js", | |||
| "linkcheck": "find ./pages -name '*.md*' -print0 | xargs -0 -n1 pnpm markdown-link-check --quiet --progress --config linkchecker-config.json", | |||
| "lint": "eslint . && vale pages/ --minAlertLevel=error", | |||
| "format": "prettier --write \"pages/**/*.{md,mdx,json}\"", | |||
There was a problem hiding this comment.
Is there a way to use standard --fix instead? Since it is already configured for the rest of the project
There was a problem hiding this comment.
Is it possible to run prettier with our configuration of standard.js (in eslint.rc)?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
This PR:
formatscript