Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix vale contractions #349

Merged
merged 4 commits into from
Feb 8, 2024
Merged

Fix vale contractions #349

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
7464d44
Fix vale contractions
Feb 8, 2024
ecf738a
Remove extra whitespace
Feb 8, 2024
253eb29
Fix missed items
Feb 8, 2024
e4d9109
Fix an error
Feb 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions pages/apps-sdk-release.mdx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ criteria:

### Smart contracts must be audited

Security is the top priority for Safe. Please provide an external audit result document if the Safe App includes smart contracts. If a third party created the smart contracts, ensure they're audited.
Security is the top priority for Safe. Please provide an external audit result document if the Safe App includes smart contracts. If a third party created the smart contracts, ensure they are audited.

### Your Safe App must include a manifest

Expand Down Expand Up @@ -63,7 +63,7 @@ Alternatively, you can provide us with the ABIs as JSON files or the links to th

## Official launch and beyond

After we've reviewed and integrated your Safe App, the App will first be available in the [staging environment](https://safe-wallet-web.staging.5afe.dev) of the Safe for you to do a final review. We would then approach you to coordinate the launch and a joint announcement.
After we have reviewed and integrated your Safe App, the App will first be available in the [staging environment](https://safe-wallet-web.staging.5afe.dev) of the Safe for you to do a final review. We would then approach you to coordinate the launch and a joint announcement.

At any point after the launch, if you or your users encounter issues with the Safe App or want to release an update to an existing Safe App, please contact us via [Discord](https://chat.safe.global).

Expand Down
2 changes: 1 addition & 1 deletion pages/bug-bounty.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# Bug Bounty

Participate in the Safe Bug Bounty program to find bugs and get rewards. Earn up to $1,000,000 for every bug you report. Please carefully read through the [submission process](./bug-bounty.md#submission-process) section and get in touch via [[email protected]](mailto:[email protected]). You can also review the [bug bounties](./bug-bounty/past-paid-bounties.md) we've paid in the past.
Participate in the Safe Bug Bounty program to find bugs and get rewards. Earn up to $1,000,000 for every bug you report. Please carefully read through the [submission process](./bug-bounty.md#submission-process) section and get in touch via [[email protected]](mailto:[email protected]). You can also review the [bug bounties](./bug-bounty/past-paid-bounties.md) we have paid in the past.

Check failure on line 3 in pages/bug-bounty.md

View workflow job for this annotation

GitHub Actions / vale-docs 

[vale] reported by reviewdog 🐶
[Microsoft.Contractions] Use 'we've' instead of 'we have'.

Raw Output:
{"message": "[Microsoft.Contractions] Use 'we've' instead of 'we have'.", "location": {"path": "pages/bug-bounty.md", "range": {"start": {"line": 3, "column": 366}}}, "severity": "ERROR"}

## Audits

Expand Down
2 changes: 1 addition & 1 deletion pages/sdk-onramp-kit/guides/monerium.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,7 @@ const orders = await moneriumClient.getOrders()

5. When you reload a page, you usually want to stay authenticated as long as the tokens are valid. To do this, just call the `open()` method without arguments.

6. You're now ready to place orders. In the `production` environment, real funds will be transferred. In the `sandbox` environment, fake money will be used. If you add funds using the `sandbox` or create a transfer from your bank account to your Monerium IBAN in the `production` environment, you'll receive the corresponding tokens in your Safe. For example, if your Monerium IBAN is associated with the EURe token of your Safe, and you transfer 10 euros, the EURe balance of your Safe will be 10 after the SEPA system completes the transfer.
6. You are now ready to place orders. In the `production` environment, real funds will be transferred. In the `sandbox` environment, fake money will be used. If you add funds using the `sandbox` or create a transfer from your bank account to your Monerium IBAN in the `production` environment, you'll receive the corresponding tokens in your Safe. For example, if your Monerium IBAN is associated with the EURe token of your Safe, and you transfer 10 euros, the EURe balance of your Safe will be 10 after the SEPA system completes the transfer.

Add tokens to your Safe using the `sandbox`. They should be available almost instantly. You can check the balance of your assets [here](https://app.safe.global/balances) afterwards.

Expand Down
4 changes: 2 additions & 2 deletions pages/sdk-protocol-kit.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,9 +15,9 @@ For a more detailed guide, including how to integrate with `web3.js` and more Sa

### Install dependencies

First, we'll need to install some dependencies from `safe-core-sdk` and the `ethers` library.
First, we need to install some dependencies from `safe-core-sdk` and the `ethers` library.

To interact with Ethereum and other EVM blockchains in Node, we can either use: web3.js or ethers.js. In this tutorial, we'll use the ethers.js library. To use `web3js`, see [Instantiate an EthAdapter section in Guide: Integrating the Safe Core SDK](https://github.com/safe-global/safe-core-sdk/blob/main/guides/integrating-the-safe-core-sdk.md#instantiate-an-ethadapter).
To interact with Ethereum and other EVM blockchains in Node, we can either use: web3.js or ethers.js. In this tutorial, we will use the ethers.js library. To use `web3js`, see [Instantiate an EthAdapter section in Guide: Integrating the Safe Core SDK](https://github.com/safe-global/safe-core-sdk/blob/main/guides/integrating-the-safe-core-sdk.md#instantiate-an-ethadapter).

The Protocol Kit is compatible only with **ethers.js v6**. Make sure you specify this version when installing the SDK.

Expand Down
2 changes: 1 addition & 1 deletion pages/sdk-relay-kit/guides/gelato-relay.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ Currently, the Relay Kit is only compatible with the [Gelato relay](https://docs

## Gelato 1Balance

[Gelato 1Balance](https://docs.gelato.network/developer-services/relay/payment-and-fees/1balance) allows [you](you) to execute transactions using a prepaid deposit. This can be used to sponsor transactions to other Safes or even to use a deposit on Polygon to pay the fees for a wallet on another chain.
[Gelato 1Balance](https://docs.gelato.network/developer-services/relay/payment-and-fees/1balance) allows you to execute transactions using a prepaid deposit. This can be used to sponsor transactions to other Safes or even to use a deposit on Polygon to pay the fees for a wallet on another chain.

For the 1Balance quickstart tutorial, you will use the Gelato relayer to pay for the gas fees on BNB Chain using the Polygon USDC you have deposited into your Gelato 1Balance account.

Expand Down
8 changes: 4 additions & 4 deletions pages/smart-account-signatures/eip-1271.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@

### EIP-191 messages

To sign a message we've to call the `signMessage` function and pass in the message as hex string.
To sign a message we have to call the `signMessage` function and pass in the message as hex string.

Check failure on line 24 in pages/smart-account-signatures/eip-1271.md

View workflow job for this annotation

GitHub Actions / vale-docs 

[vale] reported by reviewdog 🐶
[Microsoft.Contractions] Use 'we've' instead of 'we have'.

Raw Output:
{"message": "[Microsoft.Contractions] Use 'we've' instead of 'we have'.", "location": {"path": "pages/smart-account-signatures/eip-1271.md", "range": {"start": {"line": 24, "column": 19}}}, "severity": "ERROR"}

The signing request will be blocked until the message is fully signed and then return the `signature` as a string.
As Safe{Wallet} is a multi signature wallet, this process can take some time because multiple signers may need to sign the message.
Expand All @@ -41,7 +41,7 @@

### EIP-712 typed data

To sign typed data we've to call the `signTypedData` function and pass in the typed data object.
To sign typed data we have to call the `signTypedData` function and pass in the typed data object.

Check failure on line 44 in pages/smart-account-signatures/eip-1271.md

View workflow job for this annotation

GitHub Actions / vale-docs 

[vale] reported by reviewdog 🐶
[Microsoft.Contractions] Use 'we've' instead of 'we have'.

Raw Output:
{"message": "[Microsoft.Contractions] Use 'we've' instead of 'we have'.", "location": {"path": "pages/smart-account-signatures/eip-1271.md", "range": {"start": {"line": 44, "column": 20}}}, "severity": "ERROR"}

The signing request will be blocked until the message is fully signed and then return the `signature` as a string.
As Safe{Wallet} is a multi signature wallet, this process can take some time because multiple signers may need to sign the message.
Expand All @@ -65,7 +65,7 @@
name: 'EIP-1271 Example DApp',
version: '1.0',
chainId: 1,
verifyingContract: '0x123..456',
[verifyingContract](verifyingContract): '0x123..456',
},
message: {
content: 'Hello World!',
Expand All @@ -88,7 +88,7 @@

You can fetch the signature asynchronously instead of waiting for the RPC response via the [Safe Transaction Service](https://github.com/safe-global/safe-transaction-service).

To do so we've to generate a hash of the `message` or `typedData` using ethers `hashMessage(message)` or `_TypedDataEncoder.hash(domain, types, message)` and then compute the `Safe message hash` by calling `getMessageHash(messageHash)` on the Safe contract.
To do so we have to generate a hash of the `message` or `typedData` using ethers `hashMessage(message)` or `_TypedDataEncoder.hash(domain, types, message)` and then compute the `Safe message hash` by calling `getMessageHash(messageHash)` on the Safe contract.

Check failure on line 91 in pages/smart-account-signatures/eip-1271.md

View workflow job for this annotation

GitHub Actions / vale-docs 

[vale] reported by reviewdog 🐶
[Microsoft.Contractions] Use 'we've' instead of 'we have'.

Raw Output:
{"message": "[Microsoft.Contractions] Use 'we've' instead of 'we have'.", "location": {"path": "pages/smart-account-signatures/eip-1271.md", "range": {"start": {"line": 91, "column": 10}}}, "severity": "ERROR"}

### Example: Get Safe message hash

Expand Down
Loading