Skip to content

Commit

Permalink
Validate resources in prepush commit hook rather than github action w…
Browse files Browse the repository at this point in the history
…orkflow
  • Loading branch information
louis-md committed Mar 22, 2024
1 parent 310dc5a commit 8e8f90c
Show file tree
Hide file tree
Showing 3 changed files with 15 additions and 28 deletions.
21 changes: 14 additions & 7 deletions .github/scripts/validateResources.js
Original file line number Diff line number Diff line change
Expand Up @@ -5,29 +5,36 @@ const communityResourcesPath =
'./components/ResourceHub/community-resources.json'

const validateResource = (resource, index, resources) => {
const errorMessage = resourcesPath + ':1:1:'
if (resources.findIndex(r => r.url === resource.url) !== index) {
console.log(errorMessage + `Duplicate resource: ${resource.url}`)
console.log(`Duplicate resource`)
return false
}
if (!resource.name) {
console.log(errorMessage + `Resource name is missing: ${resource.url}`)
console.log(`Resource name is missing`)
return false
}
if (!resource.type) {
console.log(errorMessage + `Resource type is missing: ${resource.url}`)
console.log(`Resource type is missing`)
return false
}
if (!resource.date) {
console.log(errorMessage + `Resource date is missing: ${resource.url}`)
console.log(`Resource date is missing`)
return false
}
if (!resource.description) {
console.log(errorMessage + `Resource description is missing: ${resource.url}`)
console.log(`Resource description is missing`)
return false
}
if (!resource.tags || !resource.tags.length) {
console.log(errorMessage + `Resource tags are missing: ${resource.url}`)
console.log(errorMessage + `Resource tags are missing`)
return false
}
if (
resource.url.includes('youtube') &&
(!resource.url.startsWith('https://www.youtube.com/watch?v=') ||
resource.url.length !== 43)
) {
console.log(`Invalid YouTube URL`)
return false
}
return true
Expand Down
20 changes: 0 additions & 20 deletions .github/workflows/resource-check.yml

This file was deleted.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
"start": "serve out",
"test": "env-cmd cypress run --headless",
"typecheck": "tsc --noEmit --incremental false",
"prepush": "pnpm lint && pnpm typecheck",
"prepush": "pnpm lint && pnpm typecheck && pnpm validate-resources",
"prepare": "husky install"
},
"repository": {
Expand Down

0 comments on commit 8e8f90c

Please sign in to comment.