fix: Handle 0 safeTxGas when passed to createTransaction call #309
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA Assistant Lite All Contributors have signed the CLA. |
mmv08
reviewed
Dec 11, 2022
| @@ -147,7 +147,7 @@ describe('Transactions creation', () => { | |||
| safeAddress: safe.address, | |||
| contractNetworks | |||
| }) | |||
| const safeTxGas = 111 | |||
| const safeTxGas = 0 | |||
There was a problem hiding this comment.
Why this change? For this test it should be irrelevant if it's 0 or 111 ("should return a transaction with defined safeTxGas if safeVersion<1.3.0")
There was a problem hiding this comment.
I think I get it but i'd a add a separate test for handling falsy values
There was a problem hiding this comment.
Yeah, I was thinking its the edge value that caused the issue so rather have a test for it but I will add another.
usame-algan
force-pushed
the
fix-safetxgas
branch
from
9a96005 to
3bf0f55
Compare
mmv08
approved these changes
Dec 12, 2022
|
wait for a review from @germartinez cos he's the code owner :) |
germartinez
approved these changes
Dec 14, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it solves
Resolves #1343
If a transaction is created with 0 safeTxGas in the web-core UI and another owner tries to sign it, the
createTransactioncall from the SDK will return a non 0 safeTxGas which causes issues with the existing txData (such as gasLimit estimation failing).How this PR fixes it
Narrow the condition to check for
undefinedso that asafeTxGasof 0 is caught by it.