Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update README.md for safe-ethers-adapters #283

Merged
merged 2 commits into from
Nov 10, 2022
Merged

Update README.md for safe-ethers-adapters #283

merged 2 commits into from
Nov 10, 2022

Conversation

rellfy
Copy link
Contributor

@rellfy rellfy commented Nov 8, 2022

What it solves

  • Updates the instructions for the safe-ethers-adapters package, using the correct types/values.
  • Fixes the examples link. Currently, in NPM, it redirects to the /examples root directory of the repo rather than the package's /examples.

@github-actions
Copy link

github-actions bot commented Nov 8, 2022 •
edited
Loading

CLA Assistant Lite All Contributors have signed the CLA.

@rellfy
Copy link
Contributor Author

rellfy commented Nov 8, 2022

I have read the CLA Document and I hereby sign the CLA

@germartinez germartinez self-requested a review November 10, 2022 18:01
@germartinez
Copy link
Member

Indeed, that README file was not up to date.
Thank you very much for this PR!

@germartinez germartinez merged commit c74017a into safe-global:main Nov 10, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Nov 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@germartinez germartinez germartinez approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rellfy @germartinez