Allow the initialization of EthAdapter with providers instead of signers #260
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA Assistant Lite All Contributors have signed the CLA. |
germartinez
changed the title
germartinez
changed the title
germartinez
force-pushed
the
no-signer
branch
from
4288a66 to
7fb8305
Compare
germartinez
force-pushed
the
no-signer
branch
from
7fb8305 to
5f508e4
Compare
iamacook
approved these changes
Oct 28, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it solves
So far new instances of the
EthAdapterclass required a signer in the constructor. This PR allows to pass just a provider, restricting some of the methods for the ethAdapters that were initialized with a signer.This logic was also expanded to the Safe Core SDK and the Safe Service Client.