Rename methods and error messages #251
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA Assistant Lite All Contributors have signed the CLA. |
iamacook
reviewed
Aug 30, 2022
| @@ -651,12 +651,12 @@ const txHash = await safeSdk.getTransactionHash(safeTransaction) | |||
| const owners = await safeSdk.getOwnersWhoApprovedTx(txHash) | |||
| ``` | |||
|
|
|||
| ### getEnableModuleTx | |||
| ### createEnableModuleTx | |||
There was a problem hiding this comment.
Should we format these? i.e.
Suggested change
| ### createEnableModuleTx | |
| ### `createEnableModuleTx` |
There was a problem hiding this comment.
I'm personally not a fan of using `` in titles like these from the visuals perspective. I found ENS is doing it this way, but also not sure which one is better. I think I prefer to keep the method names as they are, all together.
WDYT?
iamacook
approved these changes
Aug 30, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it solves
Taking advantage of the next mayor release, this PR:
Example:
const safeTx = getAddOwnerTx(...)->const safeTx = createAddOwnerTx(...)Example:
Error: [...] Multi Send contract [...]->Error: [...] MultiSend contract [...]