Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make signTransaction method immutable #246

Merged
merged 1 commit into from
Aug 24, 2022
Merged

Make signTransaction method immutable #246

merged 1 commit into from
Aug 24, 2022

Conversation

germartinez
Copy link
Member

What it solves

This PR makes immutable the signTransaction method from the Core SDK by not adding the signature to the passed safeTransaction argument.

@github-actions
Copy link

CLA Assistant Lite All Contributors have signed the CLA.

katspaugh
katspaugh approved these changes Aug 24, 2022
View reviewed changes
Copy link
Member

@katspaugh katspaugh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@germartinez germartinez merged commit 24c46da into development Aug 24, 2022
@germartinez germartinez deleted the signtx-full-immutable branch August 24, 2022 19:43
@github-actions github-actions bot locked and limited conversation to collaborators Aug 24, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@katspaugh katspaugh katspaugh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@germartinez @katspaugh