Support EIP-1559 #234
Merged
Support EIP-1559 #234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA Assistant Lite All Contributors have signed the CLA. |
usame-algan
reviewed
Aug 1, 2022
Comment on lines
+16
to
+17
| maxFeePerGas?: number | string | ||
| maxPriorityFeePerGas?: number | string |
There was a problem hiding this comment.
Is there a reason we support string here but not for gasPrice?
There was a problem hiding this comment.
Given the regular values that gasPrice takes, number is enough. However, it should be a string | number like the properties that were added in this PR.
I will recheck all the types of the similar properties and update them in a new PR
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it solves
Resolves #206