Fix signTypedData #220
Merged
Fix signTypedData #220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA Assistant Lite All Contributors have signed the CLA. |
schmanu
reviewed
Jul 14, 2022
| @@ -68,5 +67,8 @@ export function generateTypedData({ | |||
| nonce: BigNumber.from(safeTransactionData.nonce) | |||
| } | |||
| } | |||
| if (eip712WithChainId) { | |||
| typedData.domain.chainId = chainId | |||
There was a problem hiding this comment.
I guess the error was caused because ethers would try to encode undefined instead of ignoring it if the key is present?
Would it be possible to unit-test this? I feel like this is missed / refactored wrong easily.
There was a problem hiding this comment.
Yes, that was exactly the issue ;)
I'll add some tests to cover that
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it solves
Fixes the error
[Error: invalid BigNumber value (argument="value", value=undefined, code=INVALID_ARGUMENT, version=bignumber/5.6.2)](https://ethereum.stackexchange.com/questions/130776/error-invalid-bignumber-value-argument-value-value-undefined-code-invalid)for Safes with version<v1.3.0.This issue was caused because
chainIdhad a wrong type makingsigner._signTypedData()complain about it.