Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix contract calls in class GnosisSafeContract_V1_1_1 #134

Merged
merged 1 commit into from
Jan 5, 2022

Conversation

germartinez
Copy link
Member

What it solves

super.contract is undefined in classes GnosisSafeContract_V1_1_1_Ethers and GnosisSafeContract_V1_1_1_Web3

How this PR fixes it

Call this.contract

@github-actions
Copy link

github-actions bot commented Jan 5, 2022

CLA Assistant Lite All Contributors have signed the CLA.

Copy link
Member

@iamacook iamacook left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It might be safer to create a type check function instead of casting?

Sorry, I read it backwards 🤦‍♂️

Copy link
Member

@iamacook iamacook left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@germartinez germartinez merged commit b6bfb71 into development Jan 5, 2022
@germartinez germartinez deleted the fix-super-contract branch January 5, 2022 12:08
@github-actions github-actions bot locked and limited conversation to collaborators Jan 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants